Fix pgstat_heap() to not be broken by syncscans starting from a block

tglsfdc · tglsfdc · commit b775d93acb96 · 2008-01-14T02:53:31.000Z
higher than zero.  Same problem as just detected in CREATE INDEX
CONCURRENTLY.
diff --git a/contrib/pgstattuple/pgstattuple.c b/contrib/pgstattuple/pgstattuple.c
@@ -1,5 +1,5 @@
 /*
- * $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.31 2007/10/22 17:29:35 tgl Exp $
+ * $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.32 2008/01/14 02:53:31 tgl Exp $
  *
  * Copyright (c) 2001,2002	Tatsuo Ishii
  *
@@ -255,7 +255,8 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)
 	Buffer		buffer;
 	pgstattuple_type stat = {0};
 
-	scan = heap_beginscan(rel, SnapshotAny, 0, NULL);
+	/* Disable syncscan because we assume we scan from block zero upwards */
+	scan = heap_beginscan_strat(rel, SnapshotAny, 0, NULL, true, false);
 
 	nblocks = scan->rs_nblocks; /* # blocks to be scanned */
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.31 2007/10/22 17:29:35 tgl Exp $`
	`2`	`+ * $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.32 2008/01/14 02:53:31 tgl Exp $`
`3`	`3`	`*`
`4`	`4`	`* Copyright (c) 2001,2002 Tatsuo Ishii`
`5`	`5`	`*`
`@@ -255,7 +255,8 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)`
`255`	`255`	`Buffer buffer;`
`256`	`256`	`pgstattuple_type stat = {0};`
`257`	`257`
`258`		`- scan = heap_beginscan(rel, SnapshotAny, 0, NULL);`
	`258`	`+ /* Disable syncscan because we assume we scan from block zero upwards */`
	`259`	`+ scan = heap_beginscan_strat(rel, SnapshotAny, 0, NULL, true, false);`
`259`	`260`
`260`	`261`	`nblocks = scan->rs_nblocks; /* # blocks to be scanned */`
`261`	`262`