Add more comments about thousands separator handling.

bmomjian · bmomjian · commit b85cf684f76f · 2007-11-22T17:51:39.000Z
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.135 2007/11/22 15:10:05 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.136 2007/11/22 17:51:39 momjian Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2007, PostgreSQL Global Development Group
@@ -3926,6 +3926,7 @@ NUM_prepare_locale(NUMProc *Np)
 		 *
 		 * Some locales (e.g. broken glibc pt_BR), have a comma for decimal,
 		 * but "" for thousands_sep, so we set the thousands_sep too.
+		 * http://archives.postgresql.org/pgsql-hackers/2007-11/msg00772.php
 		 */
 		if (lconv->thousands_sep && *lconv->thousands_sep)
 			Np->L_thousands_sep = lconv->thousands_sep;
diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
@@ -3,7 +3,7 @@
  *
  * Copyright (c) 2000-2007, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.93 2007/11/22 15:10:05 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.94 2007/11/22 17:51:39 momjian Exp $
  *
  * Note: we include postgres.h not postgres_fe.h so that we can include
  * catalog/pg_type.h, and thereby have access to INT4OID and similar macros.
@@ -2037,6 +2037,8 @@ setDecimalLocale(void)
 		grouping = strdup(extlconv->grouping);
 	else
 		grouping = "3";			/* most common */
+
+	/* similar code exists in formatting.c */
 	if (*extlconv->thousands_sep)
 		thousands_sep = strdup(extlconv->thousands_sep);
 	/* Make sure thousands separator doesn't match decimal point symbol. */

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.135 2007/11/22 15:10:05 momjian Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.136 2007/11/22 17:51:39 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2007, PostgreSQL Global Development Group`
`@@ -3926,6 +3926,7 @@ NUM_prepare_locale(NUMProc *Np)`
`3926`	`3926`	`*`
`3927`	`3927`	`* Some locales (e.g. broken glibc pt_BR), have a comma for decimal,`
`3928`	`3928`	`* but "" for thousands_sep, so we set the thousands_sep too.`
	`3929`	`+ * http://archives.postgresql.org/pgsql-hackers/2007-11/msg00772.php`
`3929`	`3930`	`*/`
`3930`	`3931`	`if (lconv->thousands_sep && *lconv->thousands_sep)`
`3931`	`3932`	`Np->L_thousands_sep = lconv->thousands_sep;`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright (c) 2000-2007, PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.93 2007/11/22 15:10:05 momjian Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/bin/psql/print.c,v 1.94 2007/11/22 17:51:39 momjian Exp $`
`7`	`7`	`*`
`8`	`8`	`* Note: we include postgres.h not postgres_fe.h so that we can include`
`9`	`9`	`* catalog/pg_type.h, and thereby have access to INT4OID and similar macros.`
`@@ -2037,6 +2037,8 @@ setDecimalLocale(void)`
`2037`	`2037`	`grouping = strdup(extlconv->grouping);`
`2038`	`2038`	`else`
`2039`	`2039`	`grouping = "3"; /* most common */`
	`2040`	`+`
	`2041`	`+ /* similar code exists in formatting.c */`
`2040`	`2042`	`if (*extlconv->thousands_sep)`
`2041`	`2043`	`thousands_sep = strdup(extlconv->thousands_sep);`
`2042`	`2044`	`/* Make sure thousands separator doesn't match decimal point symbol. */`