Add missing pstrdup

alvherre · alvherre · commit bc972072a3bb · 2018-04-23T12:11:41.000-03:00
Lifetime of the input string is not right, so create a separate copy. Author: Amit Langote Discussion: https://postgr.es/m/a2773420-50d1-0a42-3396-fe42b0921134@lab.ntt.co.jp
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -14568,7 +14568,8 @@ CloneRowTriggersToPartition(Relation parent, Relation partition)
 
 				col = TupleDescAttr(parent->rd_att,
 									trigForm->tgattr.values[i] - 1);
-				cols = lappend(cols, makeString(NameStr(col->attname)));
+				cols = lappend(cols,
+							   makeString(pstrdup(NameStr(col->attname))));
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -14568,7 +14568,8 @@ CloneRowTriggersToPartition(Relation parent, Relation partition)`
`14568`	`14568`
`14569`	`14569`	`col = TupleDescAttr(parent->rd_att,`
`14570`	`14570`	`trigForm->tgattr.values[i] - 1);`
`14571`		`- cols = lappend(cols, makeString(NameStr(col->attname)));`
	`14571`	`+ cols = lappend(cols,`
	`14572`	`+ makeString(pstrdup(NameStr(col->attname))));`
`14572`	`14573`	`}`
`14573`	`14574`	`}`
`14574`	`14575`