Avoid archiving XLOG_RUNNING_XACTS on idle server

simonat2ndQuadrant · simonat2ndQuadrant · commit bf08f2292ffc · 2016-04-04T07:18:05.000+01:00
If archive_timeout &gt; 0 we should avoid logging XLOG_RUNNING_XACTS if idle.

Bug 13685 reported by Laurence Rowe, investigated in detail by Michael Paquier,
though this is not his proposed fix.
20151016203031.3019.72930@wrigleys.postgresql.org

Simple non-invasive patch to allow later backpatch to 9.4 and 9.5
diff --git a/src/backend/postmaster/bgwriter.c b/src/backend/postmaster/bgwriter.c
@@ -330,8 +330,11 @@ BackgroundWriterMain(void)
 			if (now >= timeout &&
 				last_snapshot_lsn != GetXLogInsertRecPtr())
 			{
-				last_snapshot_lsn = LogStandbySnapshot();
+				XLogRecPtr log_standby_lsn = LogStandbySnapshot();
+
 				last_snapshot_ts = now;
+				if (!XLogRecPtrIsInvalid(log_standby_lsn))
+					last_snapshot_lsn = log_standby_lsn;
 			}
 		}
 
diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
@@ -902,6 +902,7 @@ LogStandbySnapshot(void)
 	RunningTransactions running;
 	xl_standby_lock *locks;
 	int			nlocks;
+	static bool last_snapshot_overflowed = false;
 
 	Assert(XLogStandbyInfoActive());
 
@@ -932,8 +933,28 @@ LogStandbySnapshot(void)
 	 * only a shared lock.
 	 */
 	if (wal_level < WAL_LEVEL_LOGICAL)
+	{
 		LWLockRelease(ProcArrayLock);
 
+		/*
+		 * Don't bother to log anything if nothing is happening, if we are
+		 * using archive_timeout > 0 and we didn't overflow snapshot last time.
+		 *
+		 * This ensures that we don't issue an empty WAL record, which can
+		 * be annoying when used in conjunction with archive timeout.
+		 */
+		if (running->xcnt == 0 &&
+			nlocks == 0 &&
+			XLogArchiveTimeout > 0 &&
+			!last_snapshot_overflowed)
+		{
+			LWLockRelease(XidGenLock);
+			return InvalidXLogRecPtr;
+		}
+
+		last_snapshot_overflowed = running->subxid_overflow;
+	}
+
 	recptr = LogCurrentRunningXacts(running);
 
 	/* Release lock if we kept it longer ... */

Original file line number	Diff line number	Diff line change
`@@ -330,8 +330,11 @@ BackgroundWriterMain(void)`
`330`	`330`	`if (now >= timeout &&`
`331`	`331`	`last_snapshot_lsn != GetXLogInsertRecPtr())`
`332`	`332`	`{`
`333`		`- last_snapshot_lsn = LogStandbySnapshot();`
	`333`	`+ XLogRecPtr log_standby_lsn = LogStandbySnapshot();`
	`334`	`+`
`334`	`335`	`last_snapshot_ts = now;`
	`336`	`+ if (!XLogRecPtrIsInvalid(log_standby_lsn))`
	`337`	`+ last_snapshot_lsn = log_standby_lsn;`
`335`	`338`	`}`
`336`	`339`	`}`
`337`	`340`