Remove the prohibition on executing cursor commands through SPI_execute.

tglsfdc · tglsfdc · commit bf8236526be8 · 2007-03-25T23:27:59.000Z
Vadim had included this restriction in the original design of the SPI code,
but I'm darned if I can see a reason for it.

I left the macro definition of SPI_ERROR_CURSOR in place, so as not to
needlessly break any SPI callers that are checking for it, but that code
will never actually be returned anymore.
diff --git a/doc/src/sgml/spi.sgml b/doc/src/sgml/spi.sgml
@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/spi.sgml,v 1.54 2007/03/15 23:12:06 tgl Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/spi.sgml,v 1.55 2007/03/25 23:27:59 tgl Exp $ -->
 
 <chapter id="spi">
  <title>Server Programming Interface</title>
@@ -554,21 +554,11 @@ typedef struct
      </listitem>
     </varlistentry>
 
-    <varlistentry>
-     <term><symbol>SPI_ERROR_CURSOR</symbol></term>
-     <listitem>
-      <para>
-       if <command>DECLARE</>, <command>CLOSE</>, or <command>FETCH</>
-       was attempted
-      </para>
-     </listitem>
-    </varlistentry>
-
     <varlistentry>
      <term><symbol>SPI_ERROR_TRANSACTION</symbol></term>
      <listitem>
       <para>
-       if any command involving transaction manipulation was attempted
+       if a transaction manipulation command was attempted
        (<command>BEGIN</>,
        <command>COMMIT</>,
        <command>ROLLBACK</>,
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.173 2007/03/17 03:15:38 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.174 2007/03/25 23:27:59 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1155,8 +1155,6 @@ SPI_result_code_string(int code)
 			return "SPI_ERROR_OPUNKNOWN";
 		case SPI_ERROR_UNCONNECTED:
 			return "SPI_ERROR_UNCONNECTED";
-		case SPI_ERROR_CURSOR:
-			return "SPI_ERROR_CURSOR";
 		case SPI_ERROR_ARGUMENT:
 			return "SPI_ERROR_ARGUMENT";
 		case SPI_ERROR_PARAM:
@@ -1490,13 +1488,6 @@ _SPI_execute_plan(SPIPlanPtr plan, Datum *Values, const char *Nulls,
 							goto fail;
 						}
 					}
-					else if (IsA(stmt, DeclareCursorStmt) ||
-							 IsA(stmt, ClosePortalStmt) ||
-							 IsA(stmt, FetchStmt))
-					{
-						my_res = SPI_ERROR_CURSOR;
-						goto fail;
-					}
 					else if (IsA(stmt, TransactionStmt))
 					{
 						my_res = SPI_ERROR_TRANSACTION;
diff --git a/src/include/executor/spi.h b/src/include/executor/spi.h
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2007, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/include/executor/spi.h,v 1.59 2007/03/15 23:12:06 tgl Exp $
+ * $PostgreSQL: pgsql/src/include/executor/spi.h,v 1.60 2007/03/25 23:27:59 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -61,7 +61,7 @@ typedef struct _SPI_plan *SPIPlanPtr;
 #define SPI_ERROR_COPY			(-2)
 #define SPI_ERROR_OPUNKNOWN		(-3)
 #define SPI_ERROR_UNCONNECTED	(-4)
-#define SPI_ERROR_CURSOR		(-5)
+#define SPI_ERROR_CURSOR		(-5)			/* not used anymore */
 #define SPI_ERROR_ARGUMENT		(-6)
 #define SPI_ERROR_PARAM			(-7)
 #define SPI_ERROR_TRANSACTION	(-8)
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.190 2007/03/15 23:12:07 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.191 2007/03/25 23:27:59 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2327,11 +2327,6 @@ exec_prepare_plan(PLpgSQL_execstate *estate,
 				ereport(ERROR,
 						(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 						 errmsg("cannot COPY to/from client in PL/pgSQL")));
-			case SPI_ERROR_CURSOR:
-				ereport(ERROR,
-						(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-					errmsg("cannot manipulate cursors directly in PL/pgSQL"),
-						 errhint("Use PL/pgSQL's cursor features instead.")));
 			case SPI_ERROR_TRANSACTION:
 				ereport(ERROR,
 						(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
@@ -2631,11 +2626,6 @@ exec_stmt_dynexecute(PLpgSQL_execstate *estate,
 			ereport(ERROR,
 					(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 					 errmsg("cannot COPY to/from client in PL/pgSQL")));
-		case SPI_ERROR_CURSOR:
-			ereport(ERROR,
-					(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-					 errmsg("cannot manipulate cursors directly in PL/pgSQL"),
-					 errhint("Use PL/pgSQL's cursor features instead.")));
 		case SPI_ERROR_TRANSACTION:
 			ereport(ERROR,
 					(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.173 2007/03/17 03:15:38 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/executor/spi.c,v 1.174 2007/03/25 23:27:59 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1155,8 +1155,6 @@ SPI_result_code_string(int code)`
`1155`	`1155`	`return "SPI_ERROR_OPUNKNOWN";`
`1156`	`1156`	`case SPI_ERROR_UNCONNECTED:`
`1157`	`1157`	`return "SPI_ERROR_UNCONNECTED";`
`1158`		`- case SPI_ERROR_CURSOR:`
`1159`		`- return "SPI_ERROR_CURSOR";`
`1160`	`1158`	`case SPI_ERROR_ARGUMENT:`
`1161`	`1159`	`return "SPI_ERROR_ARGUMENT";`
`1162`	`1160`	`case SPI_ERROR_PARAM:`
`@@ -1490,13 +1488,6 @@ _SPI_execute_plan(SPIPlanPtr plan, Datum Values, const char Nulls,`
`1490`	`1488`	`goto fail;`
`1491`	`1489`	`}`
`1492`	`1490`	`}`
`1493`		`- else if (IsA(stmt, DeclareCursorStmt) \|\|`
`1494`		`- IsA(stmt, ClosePortalStmt) \|\|`
`1495`		`- IsA(stmt, FetchStmt))`
`1496`		`- {`
`1497`		`- my_res = SPI_ERROR_CURSOR;`
`1498`		`- goto fail;`
`1499`		`- }`
`1500`	`1491`	`else if (IsA(stmt, TransactionStmt))`
`1501`	`1492`	`{`
`1502`	`1493`	`my_res = SPI_ERROR_TRANSACTION;`