Support adding new node

knizhnik · kelvich · commit c1790a6d4a42 · 2017-11-13T02:17:32.000+03:00
diff --git a/multimaster--1.0.sql b/multimaster--1.0.sql
@@ -13,10 +13,9 @@ CREATE FUNCTION mtm.drop_node(node integer, drop_slot bool default false) RETURN
 AS 'MODULE_PATHNAME','mtm_drop_node'
 LANGUAGE C;
 
--- -- XXX: cstring as an argument breaks sanity check
--- CREATE FUNCTION mtm.add_node(conn_str cstring) RETURNS void
--- AS 'MODULE_PATHNAME','mtm_add_node'
--- LANGUAGE C;
+CREATE FUNCTION mtm.add_node(conn_str cstring) RETURNS void
+AS 'MODULE_PATHNAME','mtm_add_node'
+LANGUAGE C;
 
 -- Create replication slot for the node which was previously dropped together with it's slot 
 CREATE FUNCTION mtm.recover_node(node integer) RETURNS void
diff --git a/multimaster.c b/multimaster.c
@@ -1932,7 +1932,7 @@ static void MtmCheckControlFile(void)
 		if (f == NULL) { 
 			elog(FATAL, "Failed to create mmts_control file: %m");
 		}
-		Mtm->donorNodeId = -1;
+		Mtm->donorNodeId = MtmNodeId;
 		fprintf(f, "%s:%d\n", MtmClusterName, Mtm->donorNodeId);
 		fclose(f);
 	}
@@ -2706,7 +2706,7 @@ MtmReplicationMode MtmGetReplicationMode(int nodeId, sig_atomic_t volatile* shut
 		MtmLock(LW_EXCLUSIVE);
 		if (Mtm->status == MTM_RECOVERY) { 
 			recovery = true;
-			if ((Mtm->recoverySlot == 0 && (Mtm->donorNodeId < 0 || Mtm->donorNodeId == nodeId))
+			if ((Mtm->recoverySlot == 0 && (Mtm->donorNodeId == MtmNodeId || Mtm->donorNodeId == nodeId))
 				|| Mtm->recoverySlot == nodeId) 
 			{ 
 				/* Choose for recovery first available slot or slot of donor node (if any) */
@@ -2819,7 +2819,7 @@ MtmReplicationStartupHook(struct PGLogicalStartupHookArgs* args)
 			}				
 		} else if (strcmp("mtm_restart_pos", elem->defname) == 0) { 
 			if (elem->arg != NULL && strVal(elem->arg) != NULL) {
-				recoveryStartPos = intVal(elem->arg);
+				sscanf(strVal(elem->arg), "%lx", &recoveryStartPos);
 			} else { 
 				elog(ERROR, "Restart position is not specified");
 			}

Original file line number	Diff line number	Diff line change
`@@ -1932,7 +1932,7 @@ static void MtmCheckControlFile(void)`
`1932`	`1932`	`if (f == NULL) {`
`1933`	`1933`	`elog(FATAL, "Failed to create mmts_control file: %m");`
`1934`	`1934`	`}`
`1935`		`- Mtm->donorNodeId = -1;`
	`1935`	`+ Mtm->donorNodeId = MtmNodeId;`
`1936`	`1936`	`fprintf(f, "%s:%d\n", MtmClusterName, Mtm->donorNodeId);`
`1937`	`1937`	`fclose(f);`
`1938`	`1938`	`}`
`@@ -2706,7 +2706,7 @@ MtmReplicationMode MtmGetReplicationMode(int nodeId, sig_atomic_t volatile* shut`
`2706`	`2706`	`MtmLock(LW_EXCLUSIVE);`
`2707`	`2707`	`if (Mtm->status == MTM_RECOVERY) {`
`2708`	`2708`	`recovery = true;`
`2709`		`- if ((Mtm->recoverySlot == 0 && (Mtm->donorNodeId < 0 \|\| Mtm->donorNodeId == nodeId))`
	`2709`	`+ if ((Mtm->recoverySlot == 0 && (Mtm->donorNodeId == MtmNodeId \|\| Mtm->donorNodeId == nodeId))`
`2710`	`2710`	`\|\| Mtm->recoverySlot == nodeId)`
`2711`	`2711`	`{`
`2712`	`2712`	`/* Choose for recovery first available slot or slot of donor node (if any) */`
`@@ -2819,7 +2819,7 @@ MtmReplicationStartupHook(struct PGLogicalStartupHookArgs* args)`
`2819`	`2819`	`}`
`2820`	`2820`	`} else if (strcmp("mtm_restart_pos", elem->defname) == 0) {`
`2821`	`2821`	`if (elem->arg != NULL && strVal(elem->arg) != NULL) {`
`2822`		`- recoveryStartPos = intVal(elem->arg);`
	`2822`	`+ sscanf(strVal(elem->arg), "%lx", &recoveryStartPos);`
`2823`	`2823`	`} else {`
`2824`	`2824`	`elog(ERROR, "Restart position is not specified");`
`2825`	`2825`	`}`