Add error checking for starting a win32 service using pg_ctl.

bmomjian · bmomjian · commit c21c658b3673 · 2004-12-21T17:58:30.000Z
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -4,7 +4,7 @@
  *
  * Portions Copyright (c) 1996-2004, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.50 2004/12/21 17:38:01 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.51 2004/12/21 17:58:30 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1078,7 +1078,11 @@ pgwin32_doRunAsService(void)
 	SERVICE_TABLE_ENTRY st[] = {{register_servicename, pgwin32_ServiceMain},
 	{NULL, NULL}};
 
-	StartServiceCtrlDispatcher(st);
+	if (StartServiceCtrlDispatcher(st)) == 0)
+	{
+		write_stderr(_("%s: could not start service \"%s\": error code %d\n"), progname, register_servicename, (int) GetLastError());
+		exit(1);
+	}
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`* Portions Copyright (c) 1996-2004, PostgreSQL Global Development Group`
`6`	`6`	`*`
`7`		`- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.50 2004/12/21 17:38:01 momjian Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.51 2004/12/21 17:58:30 momjian Exp $`
`8`	`8`	`*`
`9`	`9`	`*-------------------------------------------------------------------------`
`10`	`10`	`*/`
`@@ -1078,7 +1078,11 @@ pgwin32_doRunAsService(void)`
`1078`	`1078`	`SERVICE_TABLE_ENTRY st[] = {{register_servicename, pgwin32_ServiceMain},`
`1079`	`1079`	`{NULL, NULL}};`
`1080`	`1080`
`1081`		`- StartServiceCtrlDispatcher(st);`
	`1081`	`+ if (StartServiceCtrlDispatcher(st)) == 0)`
	`1082`	`+ {`
	`1083`	`+ write_stderr(_("%s: could not start service \"%s\": error code %d\n"), progname, register_servicename, (int) GetLastError());`
	`1084`	`+ exit(1);`
	`1085`	`+ }`
`1082`	`1086`	`}`
`1083`	`1087`	`#endif`
`1084`	`1088`