ignore logical messages outside of tx

kelvich · kelvich · commit c431162376fb · 2017-11-13T02:17:31.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -3172,11 +3172,16 @@ MtmGenerateGid(char* gid)
 
 static bool MtmTwoPhaseCommit(MtmCurrentTrans* x)
 {
-	if (MtmUtilityStmt && !MyXactAccessedTempRel)
+	if (MyXactAccessedTempRel)
 	{
-		MtmProcessDDLCommand(MtmUtilityStmt);
-		pfree(MtmUtilityStmt);
-		MtmUtilityStmt = NULL;
+		/*
+		 * XXX: this tx anyway goes to subscribers later, but without
+		 * surrounding begin/commit. Probably there is more clever way
+		 * to do that.
+		 */
+		x->isDistributed = false;
+		x->csn = NULL;
+		return false;
 	}
 
 	if (!x->isReplicated && (x->isDistributed && x->containsDML)) { 
@@ -3245,15 +3250,15 @@ static void MtmProcessUtility(Node *parsetree, const char *queryString,
 		case T_CreateTableSpaceStmt:
 		case T_AlterTableSpaceOptionsStmt:
 		case T_TruncateStmt:
-		case T_CommentStmt: /* XXX: we could replicate these */;
+		case T_CommentStmt:
 		case T_PrepareStmt:
 		case T_ExecuteStmt:
 		case T_DeallocateStmt:
 		case T_NotifyStmt:
 		case T_ListenStmt:
 		case T_UnlistenStmt:
 		case T_LoadStmt:
-		case T_ClusterStmt: /* XXX: we could replicate these */;
+		case T_ClusterStmt:
 		case T_VacuumStmt:
 		case T_ExplainStmt:
 		case T_VariableShowStmt:
@@ -3263,6 +3268,16 @@ static void MtmProcessUtility(Node *parsetree, const char *queryString,
 		case T_ReindexStmt:
 		    skipCommand = true;
 			break;
+
+		/* Do not skip following unless temp object was accessed */
+		case T_CreateTableAsStmt:
+		case T_CreateStmt:
+		case T_ViewStmt:
+		case T_IndexStmt:
+		case T_DropStmt:
+			break;
+
+		/* Save GUC context for consequent DDL execution */
 		case T_DiscardStmt:
 			{
 				DiscardStmt *stmt = (DiscardStmt *) parsetree;
@@ -3279,8 +3294,6 @@ static void MtmProcessUtility(Node *parsetree, const char *queryString,
 			{
 				VariableSetStmt *stmt = (VariableSetStmt *) parsetree;
 
-				// skipCommand = true;
-
 				/* Prevent SET TRANSACTION from replication */
 				if (stmt->kind == VAR_SET_MULTI)
 					skipCommand = true;
@@ -3292,88 +3305,8 @@ static void MtmProcessUtility(Node *parsetree, const char *queryString,
 				}
 			}
 			break;
-		case T_CreateTableAsStmt:
-			// {
-			// 	/* Do not replicate temp tables */
-			// 	CreateTableAsStmt *stmt = (CreateTableAsStmt *) parsetree;
-			// 	skipCommand = stmt->into->rel->relpersistence == RELPERSISTENCE_TEMP ||
-			// 		(stmt->into->rel->schemaname && strcmp(stmt->into->rel->schemaname, "pg_temp") == 0);
-			// }
-			break;
-		case T_CreateStmt:
-			{
-				/* Do not replicate temp tables */
-				CreateStmt *stmt = (CreateStmt *) parsetree;
-				skipCommand = stmt->relation->relpersistence == RELPERSISTENCE_TEMP ||
-					(stmt->relation->schemaname && strcmp(stmt->relation->schemaname, "pg_temp") == 0);
-			}
-			break;
-		case T_ViewStmt:
-			{
-				ViewStmt *stmt = (ViewStmt *) parsetree;
-				Query	   *viewParse;
-
-				viewParse = parse_analyze((Node *) copyObject(stmt->query),
-										queryString, NULL, 0);
-				skipCommand = isQueryUsingTempRelation(viewParse) ||
-					stmt->view->relpersistence == RELPERSISTENCE_TEMP;
-				// ||
-					// (stmt->relation->schemaname && strcmp(stmt->relation->schemaname, "pg_temp") == 0);
-			}
-			break;
-		case T_IndexStmt:
-			{
-				Oid			relid;
-				Relation	rel;
-				IndexStmt *stmt = (IndexStmt *) parsetree;
-				bool		isTopLevel = (context == PROCESS_UTILITY_TOPLEVEL);
 
-				if (stmt->concurrent)
-					PreventTransactionChain(isTopLevel,
-												"CREATE INDEX CONCURRENTLY");
-
-				relid = RelnameGetRelid(stmt->relation->relname);
-
-				if (OidIsValid(relid))
-				{
-					rel = heap_open(relid, ShareLock);
-					skipCommand = rel->rd_rel->relpersistence == RELPERSISTENCE_TEMP;
-					heap_close(rel, ShareLock);
-				}
-			}
-			break;
-		case T_DropStmt:
-			{
-				DropStmt *stmt = (DropStmt *) parsetree;
-
-				if (stmt->removeType == OBJECT_TABLE)
-				{
-					RangeVar   *rv = makeRangeVarFromNameList(
-										(List *) lfirst(list_head(stmt->objects)));
-					Oid			relid = RelnameGetRelid(rv->relname);
-
-					if (OidIsValid(relid))
-					{
-						Relation	rel = heap_open(relid, ShareLock);
-						skipCommand = rel->rd_rel->relpersistence == RELPERSISTENCE_TEMP;
-						heap_close(rel, ShareLock);
-					}
-				}
-				else if (stmt->removeType == OBJECT_INDEX)
-				{
-					RangeVar   *rv = makeRangeVarFromNameList(
-										(List *) lfirst(list_head(stmt->objects)));
-					Oid			relid = RelnameGetRelid(rv->relname);
-
-					if (OidIsValid(relid))
-					{
-						Relation	irel = index_open(relid, ShareLock);
-						skipCommand = irel->rd_rel->relpersistence == RELPERSISTENCE_TEMP;
-						index_close(irel, ShareLock);
-					}
-				}
-			}
-			break;
+		/* Copy need some special care */
 	    case T_CopyStmt:
 		{
 			CopyStmt *copyStatement = (CopyStmt *) parsetree;
@@ -3404,20 +3337,9 @@ static void MtmProcessUtility(Node *parsetree, const char *queryString,
 	if (context == PROCESS_UTILITY_TOPLEVEL)
 	{
 		if (!skipCommand && !MtmTx.isReplicated) {
-			// if (MtmProcessDDLCommand(queryString)) { 
-			// 	return;
-			// }
-
-			MemoryContext oldcontext;
-
-			if (MtmUtilityStmt)
-				pfree(MtmUtilityStmt);
-
-			oldcontext = MemoryContextSwitchTo(TopMemoryContext);
-			MtmUtilityStmt = palloc(strlen(queryString) + 1);
-			MemoryContextSwitchTo(oldcontext);
-
-			strncpy(MtmUtilityStmt, queryString, strlen(queryString) + 1);
+			if (MtmProcessDDLCommand(queryString)) {
+				return;
+			}
 		}
 	}
 
diff --git a/pglogical_apply.c b/pglogical_apply.c
@@ -59,6 +59,8 @@ typedef struct TupleData
 	bool		changed[MaxTupleAttributeNumber];
 } TupleData;
 
+static bool inside_tx = false;
+
 static Relation read_rel(StringInfo s, LOCKMODE mode);
 static void read_tuple_parts(StringInfo s, Relation rel, TupleData *tup);
 static EState* create_rel_estate(Relation rel);
@@ -339,6 +341,8 @@ process_remote_begin(StringInfo s)
 	StartTransactionCommand();
     MtmJoinTransaction(&gtid, snapshot);
 
+	inside_tx = true;
+
 	MTM_LOG1("REMOTE begin node=%d xid=%d snapshot=%ld", gtid.node, gtid.xid, snapshot);
 }
 
@@ -349,9 +353,14 @@ process_remote_message(StringInfo s)
 	int rc;
 
 	stmt = pq_getmsgstring(s);
-	MTM_LOG1("utility: %s", stmt);
-	MTM_LOG3("%d: Execute utility statement %s", MyProcPid, stmt);
 
+	if (!inside_tx)
+	{
+		MTM_LOG1("%d: Ignoring utility statement %s", MyProcPid, stmt);
+		return;
+	}
+
+	MTM_LOG1("%d: Executing utility statement %s", MyProcPid, stmt);
 	SPI_connect();
 	rc = SPI_execute(stmt, false, 0);
 	SPI_finish();
@@ -631,6 +640,7 @@ process_remote_commit(StringInfo in)
 	if (flags & PGLOGICAL_CAUGHT_UP) {
 		MtmRecoveryCompleted();
 	}
+	inside_tx = false;
 }
 
 static void
@@ -950,12 +960,7 @@ void MtmExecutor(int id, void* work, size_t size)
     {    
         while (true) { 
             char action = pq_getmsgbyte(&s);
-            MTM_LOG3("%d: REMOTE process action %c", MyProcPid, action);
-#if 0
-			if (Mtm->status == MTM_RECOVERY) { 
-				MTM_LOG1("Replay action %c[%x]",   action, s.data[s.cursor]);
-			}
-#endif
+            MTM_LOG1("%d: REMOTE process action %c", MyProcPid, action);
             switch (action) {
                 /* BEGIN */
             case 'B':
