remove useless check from bgw_main_spawn_partitions()

funbringer · funbringer · commit c521f5834969 · 2016-09-01T17:08:31.000+03:00
diff --git a/src/pathman_workers.c b/src/pathman_workers.c
@@ -18,7 +18,6 @@
 #include "pathman_workers.h"
 #include "relation_info.h"
 #include "utils.h"
-#include "xact_handling.h"
 
 #include "access/htup_details.h"
 #include "access/xact.h"
@@ -360,17 +359,6 @@ bgw_main_spawn_partitions(Datum main_arg)
 		 DebugPrintDatum(value, args->value_type), MyProcPid);
 #endif
 
-	/* Check again if there's a conflicting lock */
-	if (xact_bgw_conflicting_lock_exists(args->partitioned_table))
-	{
-		elog(LOG, "%s: there's a conflicting lock on relation \"%s\"",
-			 spawn_partitions_bgw,
-			 get_rel_name_or_relid(args->partitioned_table));
-
-		dsm_detach(segment);
-		return; /* exit quickly */
-	}
-
 	/* Create partitions and save the Oid of the last one */
 	args->result = create_partitions_internal(args->partitioned_table,
 											  value, /* unpacked Datum */
diff --git a/src/xact_handling.c b/src/xact_handling.c
@@ -168,7 +168,7 @@ do_we_hold_the_lock(Oid relid, LOCKMODE lockmode)
 			return false;
 
 		default:
-			return false; /* should not happen */
+			return false;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ do_we_hold_the_lock(Oid relid, LOCKMODE lockmode)`
`168`	`168`	`return false;`
`169`	`169`
`170`	`170`	`default:`
`171`		`- return false; /* should not happen */`
	`171`	`+ return false;`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`