Skip to content

Commit cca2a27

Browse files
committed
Fix bogus comments
Some comments mentioned XLogReplayBuffer, but there's no such function: that was an interim name for a function that got renamed to XLogReadBufferForRedo, before commit 2c03216 was pushed.
1 parent bdb9e3d commit cca2a27

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/backend/access/heap/heapam.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7898,8 +7898,8 @@ heap_xlog_visible(XLogReaderState *record)
78987898
PageInit(vmpage, BLCKSZ, 0);
78997899

79007900
/*
7901-
* XLogReplayBufferExtended locked the buffer. But visibilitymap_set
7902-
* will handle locking itself.
7901+
* XLogReadBufferForRedoExtended locked the buffer. But
7902+
* visibilitymap_set will handle locking itself.
79037903
*/
79047904
LockBuffer(vmbuffer, BUFFER_LOCK_UNLOCK);
79057905

src/backend/access/transam/xlogutils.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -426,9 +426,10 @@ XLogReadBufferForRedoExtended(XLogReaderState *record,
426426
* to imply that the page should be dropped or truncated later.
427427
*
428428
* NB: A redo function should normally not call this directly. To get a page
429-
* to modify, use XLogReplayBuffer instead. It is important that all pages
430-
* modified by a WAL record are registered in the WAL records, or they will be
431-
* invisible to tools that that need to know which pages are modified.
429+
* to modify, use XLogReadBufferForRedoExtended instead. It is important that
430+
* all pages modified by a WAL record are registered in the WAL records, or
431+
* they will be invisible to tools that that need to know which pages are
432+
* modified.
432433
*/
433434
Buffer
434435
XLogReadBufferExtended(RelFileNode rnode, ForkNumber forknum,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy