Fix regression in dblink_disconnect() reported by Eduardo Stern:

jconway · jconway · commit d1824a5ccb5a · 2003-11-28T05:03:02.000Z
persistent_conn was left dangling after a disconnect in the
unnamed connection case, causing a subsequent disconnect to
crash the backend.
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
@@ -256,6 +256,8 @@ dblink_disconnect(PG_FUNCTION_ARGS)
 		deleteConnection(conname);
 		pfree(rcon);
 	}
+	else
+		persistent_conn = NULL;
 
 	PG_RETURN_TEXT_P(GET_TEXT("OK"));
 }
diff --git a/contrib/dblink/expected/dblink.out b/contrib/dblink/expected/dblink.out
@@ -185,13 +185,11 @@ SELECT dblink_disconnect();
  OK
 (1 row)
 
--- should generate "no connection to the server" error
+-- should generate "connection not available" error
 SELECT *
 FROM dblink('SELECT * FROM foo') AS t(a int, b text, c text[])
 WHERE t.a > 7;
-ERROR:  sql error
-DETAIL:  no connection to the server
-
+ERROR:  connection not available
 -- put more data into our slave table, first using arbitrary connection syntax
 -- but truncate the actual return value so we can use diff to check for success
 SELECT substr(dblink_exec('dbname=regression','INSERT INTO foo VALUES(10,''k'',''{"a10","b10","c10"}'')'),1,6);
diff --git a/contrib/dblink/sql/dblink.sql b/contrib/dblink/sql/dblink.sql
@@ -105,7 +105,7 @@ FROM dblink_fetch('rmt_foo_cursor',4) AS t(a int, b text, c text[]);
 -- close the persistent connection
 SELECT dblink_disconnect();
 
--- should generate "no connection to the server" error
+-- should generate "connection not available" error
 SELECT *
 FROM dblink('SELECT * FROM foo') AS t(a int, b text, c text[])
 WHERE t.a > 7;

Original file line number	Diff line number	Diff line change
`@@ -256,6 +256,8 @@ dblink_disconnect(PG_FUNCTION_ARGS)`
`256`	`256`	`deleteConnection(conname);`
`257`	`257`	`pfree(rcon);`
`258`	`258`	`}`
	`259`	`+ else`
	`260`	`+ persistent_conn = NULL;`
`259`	`261`
`260`	`262`	`PG_RETURN_TEXT_P(GET_TEXT("OK"));`
`261`	`263`	`}`