Fix minor memory leak in Standby startup

simonat2ndQuadrant · simonat2ndQuadrant · commit d7c45172a673 · 2016-09-08T11:20:21.000+01:00
StandbyRecoverPreparedTransactions() leaked the buffer
used for two phase state file. This was leaked once
at startup and at every shutdown checkpoint seen.

Backpatch to 9.6

Stas Kelvich
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
@@ -1886,6 +1886,8 @@ StandbyRecoverPreparedTransactions(bool overwriteOK)
 				Assert(TransactionIdFollows(subxid, xid));
 				SubTransSetParent(xid, subxid, overwriteOK);
 			}
+
+			pfree(buf);
 		}
 	}
 	FreeDir(cldir);

Original file line number	Diff line number	Diff line change
`@@ -1886,6 +1886,8 @@ StandbyRecoverPreparedTransactions(bool overwriteOK)`
`1886`	`1886`	`Assert(TransactionIdFollows(subxid, xid));`
`1887`	`1887`	`SubTransSetParent(xid, subxid, overwriteOK);`
`1888`	`1888`	`}`
	`1889`	`+`
	`1890`	`+ pfree(buf);`
`1889`	`1891`	`}`
`1890`	`1892`	`}`
`1891`	`1893`	`FreeDir(cldir);`