Allow NumericOnly to be "+ FCONST".

tglsfdc · tglsfdc · commit dd1daa03bc8e · 2017-05-29T15:19:07.000-04:00
The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 4000000000; SET regression=# set random_page_cost = +4000000000; ERROR: syntax error at or near "4000000000" (because 4000000000 is too large to be an ICONST). While there's no actual functional reason to need to write a "+", if we allow it for integers it seems like we should allow it for numerics too. It's been like that forever, so back-patch to all supported branches. Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -3688,6 +3688,7 @@ opt_by:		BY				{}
 
 NumericOnly:
 			FCONST								{ $$ = makeFloat($1); }
+			| '+' FCONST						{ $$ = makeFloat($2); }
 			| '-' FCONST
 				{
 					$$ = makeFloat($2);

Original file line number	Diff line number	Diff line change
`@@ -3688,6 +3688,7 @@ opt_by: BY {}`
`3688`	`3688`
`3689`	`3689`	`NumericOnly:`
`3690`	`3690`	`FCONST { $$ = makeFloat($1); }`
	`3691`	`+ \| '+' FCONST { $$ = makeFloat($2); }`
`3691`	`3692`	`\| '-' FCONST`
`3692`	`3693`	`{`
`3693`	`3694`	`$$ = makeFloat($2);`