applied kurt's patch to fix unlikely, but potential, string underflow

Julian Assange · Julian Assange · commit dfca092633da · 1996-08-06T20:23:14.000Z
problem in psql
diff --git a/src/bin/psql/stringutils.c b/src/bin/psql/stringutils.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.2 1996/07/28 07:08:15 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.3 1996/08/06 20:23:14 julian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -42,7 +42,7 @@ char *rightTrim(char *s)
 {
   char *sEnd;
   sEnd = s+strlen(s)-1;
-  while (isspace(*sEnd))
+  while (sEnd >= s && isspace(*sEnd))
     sEnd--;
   if (sEnd < s)
     s[0]='\0';

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.2 1996/07/28 07:08:15 scrappy Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/stringutils.c,v 1.3 1996/08/06 20:23:14 julian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -42,7 +42,7 @@ char rightTrim(char s)`
`42`	`42`	`{`
`43`	`43`	`char *sEnd;`
`44`	`44`	`sEnd = s+strlen(s)-1;`
`45`		`- while (isspace(*sEnd))`
	`45`	`+ while (sEnd >= s && isspace(*sEnd))`
`46`	`46`	`sEnd--;`
`47`	`47`	`if (sEnd < s)`
`48`	`48`	`s[0]='\0';`