pg_dump: Add missing newlines at end of messages

petere · petere · commit e1e97e93134a · 2012-06-18T23:57:00.000+03:00
diff --git a/src/bin/pg_dump/dumputils.c b/src/bin/pg_dump/dumputils.c
@@ -1323,7 +1323,7 @@ void
 on_exit_nicely(on_exit_nicely_callback function, void *arg)
 {
 	if (on_exit_nicely_index >= MAX_ON_EXIT_NICELY)
-		exit_horribly(NULL, "out of on_exit_nicely slots");
+		exit_horribly(NULL, "out of on_exit_nicely slots\n");
 	on_exit_nicely_list[on_exit_nicely_index].function = function;
 	on_exit_nicely_list[on_exit_nicely_index].arg = arg;
 	on_exit_nicely_index++;
diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c
@@ -1566,7 +1566,7 @@ buildTocEntryArrays(ArchiveHandle *AH)
 	{
 		/* this check is purely paranoia, maxDumpId should be correct */
 		if (te->dumpId <= 0 || te->dumpId > maxDumpId)
-			exit_horribly(modulename, "bad dumpId");
+			exit_horribly(modulename, "bad dumpId\n");
 
 		/* tocsByDumpId indexes all TOCs by their dump ID */
 		AH->tocsByDumpId[te->dumpId] = te;
@@ -1587,7 +1587,7 @@ buildTocEntryArrays(ArchiveHandle *AH)
 			 * item's dump ID, so there should be a place for it in the array.
 			 */
 			if (tableId <= 0 || tableId > maxDumpId)
-				exit_horribly(modulename, "bad table dumpId for TABLE DATA item");
+				exit_horribly(modulename, "bad table dumpId for TABLE DATA item\n");
 
 			AH->tableDataId[tableId] = te->dumpId;
 		}
diff --git a/src/bin/pg_dump/pg_backup_directory.c b/src/bin/pg_dump/pg_backup_directory.c
@@ -652,7 +652,7 @@ createDirectory(const char *dir)
 	 * between our two calls.
 	 */
 	if (mkdir(dir, 0700) < 0)
-		exit_horribly(modulename, "could not create directory %s: %s",
+		exit_horribly(modulename, "could not create directory %s: %s\n",
 					  dir, strerror(errno));
 }
 
@@ -667,7 +667,7 @@ prependDirectory(ArchiveHandle *AH, const char *relativeFilename)
 	dname = ctx->directory;
 
 	if (strlen(dname) + 1 + strlen(relativeFilename) + 1 > MAXPGPATH)
-		exit_horribly(modulename, "file name too long: \"%s\"", dname);
+		exit_horribly(modulename, "file name too long: \"%s\"\n", dname);
 
 	strcpy(buf, dname);
 	strcat(buf, "/");
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -2531,7 +2531,7 @@ binary_upgrade_extension_member(PQExpBuffer upgrade_buffer,
 		extobj = NULL;
 	}
 	if (extobj == NULL)
-		exit_horribly(NULL, "could not find parent extension for %s", objlabel);
+		exit_horribly(NULL, "could not find parent extension for %s\n", objlabel);
 
 	appendPQExpBuffer(upgrade_buffer,
 	  "\n-- For binary upgrade, handle extension membership the hard way\n");

Original file line number	Diff line number	Diff line change
`@@ -1323,7 +1323,7 @@ void`
`1323`	`1323`	`on_exit_nicely(on_exit_nicely_callback function, void *arg)`
`1324`	`1324`	`{`
`1325`	`1325`	`if (on_exit_nicely_index >= MAX_ON_EXIT_NICELY)`
`1326`		`- exit_horribly(NULL, "out of on_exit_nicely slots");`
	`1326`	`+ exit_horribly(NULL, "out of on_exit_nicely slots\n");`
`1327`	`1327`	`on_exit_nicely_list[on_exit_nicely_index].function = function;`
`1328`	`1328`	`on_exit_nicely_list[on_exit_nicely_index].arg = arg;`
`1329`	`1329`	`on_exit_nicely_index++;`
Original file line number	Diff line number	Diff line change
`@@ -2531,7 +2531,7 @@ binary_upgrade_extension_member(PQExpBuffer upgrade_buffer,`
`2531`	`2531`	`extobj = NULL;`
`2532`	`2532`	`}`
`2533`	`2533`	`if (extobj == NULL)`
`2534`		`- exit_horribly(NULL, "could not find parent extension for %s", objlabel);`
	`2534`	`+ exit_horribly(NULL, "could not find parent extension for %s\n", objlabel);`
`2535`	`2535`
`2536`	`2536`	`appendPQExpBuffer(upgrade_buffer,`
`2537`	`2537`	`"\n-- For binary upgrade, handle extension membership the hard way\n");`