Change PyInit_plpy to external linkage

petere · petere · commit e1f9aa4eaecd · 2011-08-18T12:59:43.000+03:00
Module initialization functions in Python 3 must have external
linkage, because PyMODINIT_FUNC does dllexport on Windows-like
platforms.  Without this change, the build with Python 3 fails on
Windows.
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
@@ -4066,7 +4066,13 @@ PLy_add_exceptions(PyObject *plpy)
 }
 
 #if PY_MAJOR_VERSION >= 3
-static PyMODINIT_FUNC
+/*
+ * Must have external linkage, because PyMODINIT_FUNC does dllexport on
+ * Windows-like platforms.
+ */
+PyMODINIT_FUNC PyInit_plpy(void);
+
+PyMODINIT_FUNC
 PyInit_plpy(void)
 {
 	PyObject   *m;

Original file line number	Diff line number	Diff line change
`@@ -4066,7 +4066,13 @@ PLy_add_exceptions(PyObject *plpy)`
`4066`	`4066`	`}`
`4067`	`4067`
`4068`	`4068`	`#if PY_MAJOR_VERSION >= 3`
`4069`		`-static PyMODINIT_FUNC`
	`4069`	`+/*`
	`4070`	`+ * Must have external linkage, because PyMODINIT_FUNC does dllexport on`
	`4071`	`+ * Windows-like platforms.`
	`4072`	`+ */`
	`4073`	`+PyMODINIT_FUNC PyInit_plpy(void);`
	`4074`	`+`
	`4075`	`+PyMODINIT_FUNC`
`4070`	`4076`	`PyInit_plpy(void)`
`4071`	`4077`	`{`
`4072`	`4078`	`PyObject *m;`