Fix DROP INDEX CONCURRENTLY IF EXISTS.

tglsfdc · tglsfdc · commit e323c5530176 · 2012-08-27T12:45:43.000-04:00
This threw ERROR, not the expected NOTICE, if the index didn't exist. The bug was actually visible in not-as-expected regression test output, so somebody wasn't paying too close attention in commit 8cb5365. Per report from Brendan Byrd.
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -4941,7 +4941,7 @@ DropStmt:	DROP drop_type IF_P EXISTS any_name_list opt_drop_behavior
 				{
 					DropStmt *n = makeNode(DropStmt);
 					n->removeType = OBJECT_INDEX;
-					n->missing_ok = FALSE;
+					n->missing_ok = TRUE;
 					n->objects = $6;
 					n->arguments = NIL;
 					n->behavior = $7;
diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
@@ -2321,7 +2321,7 @@ Indexes:
 --
 DROP INDEX CONCURRENTLY "concur_index2";				-- works
 DROP INDEX CONCURRENTLY IF EXISTS "concur_index2";		-- notice
-ERROR:  index "concur_index2" does not exist
+NOTICE:  index "concur_index2" does not exist, skipping
 -- failures
 DROP INDEX CONCURRENTLY "concur_index2", "concur_index3";
 ERROR:  DROP INDEX CONCURRENTLY does not support dropping multiple objects

Original file line number	Diff line number	Diff line change
`@@ -4941,7 +4941,7 @@ DropStmt: DROP drop_type IF_P EXISTS any_name_list opt_drop_behavior`
`4941`	`4941`	`{`
`4942`	`4942`	`DropStmt *n = makeNode(DropStmt);`
`4943`	`4943`	`n->removeType = OBJECT_INDEX;`
`4944`		`- n->missing_ok = FALSE;`
	`4944`	`+ n->missing_ok = TRUE;`
`4945`	`4945`	`n->objects = $6;`
`4946`	`4946`	`n->arguments = NIL;`
`4947`	`4947`	`n->behavior = $7;`