some triggers (excluding BEFORE\AFTER stmt) on parent table can be executed on partitions

funbringer · funbringer · commit e32f4c64da0d · 2016-05-27T18:35:18.000+03:00
diff --git a/src/partition_filter.c b/src/partition_filter.c
@@ -1,4 +1,5 @@
 #include "partition_filter.h"
+#include "utils.h"
 #include "utils/guc.h"
 #include "nodes/nodeFuncs.h"
 
@@ -220,6 +221,15 @@ getResultRelInfo(Oid partid, PartitionFilterState *state)
 #define CopyToResultRelInfo(field_name) \
 	( resultRelInfo->field_name = state->savedRelInfo->field_name )
 
+#define ResizeTriggerField(field_name, field_type) \
+	do { \
+		if (resultRelInfo->field_name) \
+			pfree(resultRelInfo->field_name); \
+		/* palloc0() is necessary here */ \
+		resultRelInfo->field_name = (field_type *) \
+			palloc0(resultRelInfo->ri_TrigDesc->numtriggers * sizeof(field_type)); \
+	} while (0)
+
 	ResultRelInfoHandle	   *resultRelInfoHandle;
 	bool					found;
 
@@ -229,14 +239,34 @@ getResultRelInfo(Oid partid, PartitionFilterState *state)
 
 	if (!found)
 	{
-		ResultRelInfo *resultRelInfo = (ResultRelInfo *) palloc(sizeof(ResultRelInfo));
+		bool			grown_up;
+		ResultRelInfo  *resultRelInfo = (ResultRelInfo *) palloc(sizeof(ResultRelInfo));
+
 		InitResultRelInfo(resultRelInfo,
 						  heap_open(partid, RowExclusiveLock),
 						  0,
 						  state->css.ss.ps.state->es_instrument);
 
 		ExecOpenIndices(resultRelInfo, state->onConflictAction != ONCONFLICT_NONE);
 
+		resultRelInfo->ri_TrigDesc = append_trigger_descs(resultRelInfo->ri_TrigDesc,
+														  state->savedRelInfo->ri_TrigDesc,
+														  &grown_up);
+		if (grown_up)
+		{
+			ResizeTriggerField(ri_TrigFunctions, FmgrInfo);
+			ResizeTriggerField(ri_TrigWhenExprs, List *);
+
+			if (resultRelInfo->ri_TrigInstrument)
+			{
+				pfree(resultRelInfo->ri_TrigInstrument);
+
+				resultRelInfo->ri_TrigInstrument =
+					InstrAlloc(resultRelInfo->ri_TrigDesc->numtriggers,
+							   state->css.ss.ps.state->es_instrument);
+			}
+		}
+
 		/* Copy necessary fields from saved ResultRelInfo */
 		CopyToResultRelInfo(ri_WithCheckOptions);
 		CopyToResultRelInfo(ri_WithCheckOptionExprs);
diff --git a/src/utils.c b/src/utils.c
@@ -141,3 +141,72 @@ check_rinfo_for_partitioned_attr(List *rinfo, Index varno, AttrNumber varattno)
 
 	return false;
 }
+
+TriggerDesc *
+append_trigger_descs(TriggerDesc *src, TriggerDesc *more, bool *grown_up)
+{
+#define CopyToTriggerDesc(bool_field_name) \
+	( new_desc->bool_field_name |= (src->bool_field_name || more->bool_field_name) )
+
+	TriggerDesc    *new_desc = (TriggerDesc *) palloc0(sizeof(TriggerDesc));
+	Trigger		   *cur_trigger;
+	int				i;
+
+	/* Quick choices */
+	if (!src && !more)
+	{
+		*grown_up = false;
+		return NULL;
+	}
+	else if (!src)
+	{
+		*grown_up = true; /* expand space for new triggers */
+		return more;
+	}
+	else if (!more)
+	{
+		*grown_up = false; /* no new triggers will be added */
+		return src;
+	}
+
+	*grown_up = true;
+	new_desc->numtriggers = src->numtriggers + more->numtriggers;
+	new_desc->triggers = palloc(new_desc->numtriggers * sizeof(Trigger));
+
+	cur_trigger = new_desc->triggers;
+
+	/* Copy triggers from 'a' */
+	for (i = 0; i < src->numtriggers; i++)
+		memcpy(cur_trigger++, &(src->triggers[i]), sizeof(Trigger));
+
+	/* Copy triggers from 'b' */
+	for (i = 0; i < more->numtriggers; i++)
+		memcpy(cur_trigger++, &(more->triggers[i]), sizeof(Trigger));
+
+	/* Copy insert bool flags */
+	CopyToTriggerDesc(trig_insert_before_row);
+	CopyToTriggerDesc(trig_insert_after_row);
+	CopyToTriggerDesc(trig_insert_instead_row);
+	CopyToTriggerDesc(trig_insert_before_statement);
+	CopyToTriggerDesc(trig_insert_after_statement);
+
+	/* Copy update bool flags */
+	CopyToTriggerDesc(trig_update_before_row);
+	CopyToTriggerDesc(trig_update_after_row);
+	CopyToTriggerDesc(trig_update_instead_row);
+	CopyToTriggerDesc(trig_update_before_statement);
+	CopyToTriggerDesc(trig_update_after_statement);
+
+	/* Copy delete bool flags */
+	CopyToTriggerDesc(trig_delete_before_row);
+	CopyToTriggerDesc(trig_delete_after_row);
+	CopyToTriggerDesc(trig_delete_instead_row);
+	CopyToTriggerDesc(trig_delete_before_statement);
+	CopyToTriggerDesc(trig_delete_after_statement);
+
+	/* Copy truncate bool flags */
+	CopyToTriggerDesc(trig_truncate_before_statement);
+	CopyToTriggerDesc(trig_truncate_after_statement);
+
+	return new_desc;
+}
diff --git a/src/utils.h b/src/utils.h
@@ -31,4 +31,8 @@ bool check_rinfo_for_partitioned_attr(List *rinfo,
 									  Index varno,
 									  AttrNumber varattno);
 
+TriggerDesc * append_trigger_descs(TriggerDesc *src,
+								  TriggerDesc *more,
+								  bool *grown_up);
+
 #endif
