Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

adunstan · adunstan · commit e33884d4122b · 2019-01-11T17:12:54.000-05:00
This was an oversight in commit 3b174b1. Per offline gripe from Alvaro Herrera Backpatch to release 11.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -9648,6 +9648,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 			Datum       valuesAtt[Natts_pg_attribute];
 			bool        nullsAtt[Natts_pg_attribute];
 			bool        replacesAtt[Natts_pg_attribute];
+			HeapTuple   newTup;
 
 			MemSet(valuesAtt, 0, sizeof(valuesAtt));
 			MemSet(nullsAtt, false, sizeof(nullsAtt));
@@ -9673,8 +9674,10 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 			replacesAtt[Anum_pg_attribute_attmissingval - 1] = true;
 			nullsAtt[Anum_pg_attribute_attmissingval - 1] = false;
 
-			heapTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation),
-										valuesAtt, nullsAtt, replacesAtt);
+			newTup = heap_modify_tuple(heapTup, RelationGetDescr(attrelation),
+									   valuesAtt, nullsAtt, replacesAtt);
+			heap_freetuple(heapTup);
+			heapTup = newTup;
 			attTup = (Form_pg_attribute) GETSTRUCT(heapTup);
 		}
 	}
