In parse_bool_with_len, avoid crash when no result pointer is passed. Probably

petere · petere · commit e6e1ff7d042c · 2009-03-09T16:49:12.000Z
an unlikely call mode, but better be safe.
diff --git a/src/backend/utils/adt/bool.c b/src/backend/utils/adt/bool.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/bool.c,v 1.46 2009/03/09 14:34:34 petere Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/bool.c,v 1.47 2009/03/09 16:49:12 petere Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -109,7 +109,8 @@ parse_bool_with_len(const char *value, size_t len, bool *result)
 			break;
 	}
 
-	*result = false;	/* suppress compiler warning */
+	if (result)
+		*result = false;	/* suppress compiler warning */
 	return false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/bool.c,v 1.46 2009/03/09 14:34:34 petere Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/bool.c,v 1.47 2009/03/09 16:49:12 petere Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -109,7 +109,8 @@ parse_bool_with_len(const char value, size_t len, bool result)`
`109`	`109`	`break;`
`110`	`110`	`}`
`111`	`111`
`112`		`- result = false; / suppress compiler warning */`
	`112`	`+ if (result)`
	`113`	`+ result = false; / suppress compiler warning */`
`113`	`114`	`return false;`
`114`	`115`	`}`
`115`	`116`