> Mph. It fails for me too when I use --enable-integer-datetimes. Looks

bmomjian · bmomjian · commit e733510d5d67 · 2003-03-20T04:49:18.000Z
&gt; like that patch still needs some work...

Yeah.  I'm really, really, *really* sorry for submitting it in the state
it was in.  I shouldn't have done that just before moving to another
country.  I found the problem last night, but couldn't get to a Net
connection until now.

The problem is in src/bin/psql/common.c, around line 250-335 somewhere
depending on the version.  The 2nd and 3rd clauses of the "while" loop
condition:

        (rstatus == PGRES_COPY_IN) &amp;&amp;
        (rstatus == PGRES_COPY_OUT))

should of course be:

        (rstatus != PGRES_COPY_IN) &amp;&amp;
        (rstatus != PGRES_COPY_OUT))

Jeroen T. Vermeulen
diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
@@ -3,7 +3,7 @@
  *
  * Copyright 2000 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.57 2003/03/18 22:15:44 petere Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.58 2003/03/20 04:49:18 momjian Exp $
  */
 #include "postgres_fe.h"
 #include "common.h"
@@ -252,8 +252,8 @@ PSQLexec(const char *query, bool ignore_command_ok)
 			}
 			PQclear(res);
 			res = newres;
-			if (rstatus == PGRES_COPY_IN ||
-				rstatus == PGRES_COPY_OUT)
+			if (rstatus != PGRES_COPY_IN &&
+				rstatus != PGRES_COPY_OUT)
 				break;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.57 2003/03/18 22:15:44 petere Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.58 2003/03/20 04:49:18 momjian Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include "postgres_fe.h"`
`9`	`9`	`#include "common.h"`
`@@ -252,8 +252,8 @@ PSQLexec(const char *query, bool ignore_command_ok)`
`252`	`252`	`}`
`253`	`253`	`PQclear(res);`
`254`	`254`	`res = newres;`
`255`		`- if (rstatus == PGRES_COPY_IN \|\|`
`256`		`- rstatus == PGRES_COPY_OUT)`
	`255`	`+ if (rstatus != PGRES_COPY_IN &&`
	`256`	`+ rstatus != PGRES_COPY_OUT)`
`257`	`257`	`break;`
`258`	`258`	`}`
`259`	`259`	`}`