ShmemInitHash forgot to specify HASH_ALLOC flag bit in its hash_create

tglsfdc · tglsfdc · commit e8aa10ee47cd · 2003-12-30T00:03:03.000Z
call.  You'd think this would cause some problems, but because of the
way hash_create is coded, the only side-effect was creation of a useless
memory context for the hashtable.
diff --git a/src/backend/storage/ipc/shmem.c b/src/backend/storage/ipc/shmem.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/ipc/shmem.c,v 1.76 2003/12/21 04:30:10 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/ipc/shmem.c,v 1.77 2003/12/30 00:03:03 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -281,7 +281,7 @@ ShmemInitHash(const char *name, /* table string name for shmem index */
 	 */
 	infoP->dsize = infoP->max_dsize = hash_select_dirsize(max_size);
 	infoP->alloc = ShmemAlloc;
-	hash_flags |= HASH_SHARED_MEM | HASH_DIRSIZE;
+	hash_flags |= HASH_SHARED_MEM | HASH_ALLOC | HASH_DIRSIZE;
 
 	/* look it up in the shmem index */
 	location = ShmemInitStruct(name,

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/ipc/shmem.c,v 1.76 2003/12/21 04:30:10 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/ipc/shmem.c,v 1.77 2003/12/30 00:03:03 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -281,7 +281,7 @@ ShmemInitHash(const char name, / table string name for shmem index */`
`281`	`281`	`*/`
`282`	`282`	`infoP->dsize = infoP->max_dsize = hash_select_dirsize(max_size);`
`283`	`283`	`infoP->alloc = ShmemAlloc;`
`284`		`- hash_flags \|= HASH_SHARED_MEM \| HASH_DIRSIZE;`
	`284`	`+ hash_flags \|= HASH_SHARED_MEM \| HASH_ALLOC \| HASH_DIRSIZE;`
`285`	`285`
`286`	`286`	`/* look it up in the shmem index */`
`287`	`287`	`location = ShmemInitStruct(name,`