Skip to content

Commit ea56b06

Browse files
committed
Fix wrong keysize in PrivateRefCountHash creation.
In 4b4b680 I accidentally used sizeof(PrivateRefCountArray) instead of sizeof(PrivateRefCountEntry) when creating the refcount overflow hashtable. As the former is bigger than the latter, this luckily only resulted in a slightly increased memory usage when many buffers are pinned in a backend. Reported-By: Takashi Horikawa Discussion: 73FA3881462C614096F815F75628AFCD035A48C3@BPXM01GP.gisp.nec.co.jp Backpatch: 9.5, where thew new ref count infrastructure was introduced
1 parent 64a169d commit ea56b06

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/backend/storage/buffer/bufmgr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,7 @@ InitBufferPoolAccess(void)
21662166

21672167
MemSet(&hash_ctl, 0, sizeof(hash_ctl));
21682168
hash_ctl.keysize = sizeof(int32);
2169-
hash_ctl.entrysize = sizeof(PrivateRefCountArray);
2169+
hash_ctl.entrysize = sizeof(PrivateRefCountEntry);
21702170

21712171
PrivateRefCountHash = hash_create("PrivateRefCount", 100, &hash_ctl,
21722172
HASH_ELEM | HASH_BLOBS);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy