Make ExecInitExpr build the list of SubPlans found in a plan tree in order

tglsfdc · tglsfdc · commit eb4c723e562c · 2009-04-05T20:32:06.000Z
of discovery, rather than reverse order.  This doesn't matter functionally
(I suppose the previous coding dates from the time when lcons was markedly
cheaper than lappend).  However now that EXPLAIN is labeling subplans with
IDs that are based on order of creation, this may help produce a slightly
less surprising printout.
diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.244 2009/04/02 22:39:29 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.245 2009/04/05 20:32:06 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4326,7 +4326,7 @@ ExecInitExpr(Expr *node, PlanState *parent)
 				sstate = ExecInitSubPlan(subplan, parent);
 
 				/* Add SubPlanState nodes to parent->subPlan */
-				parent->subPlan = lcons(sstate, parent->subPlan);
+				parent->subPlan = lappend(parent->subPlan, sstate);
 
 				state = (ExprState *) sstate;
 			}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.244 2009/04/02 22:39:29 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/executor/execQual.c,v 1.245 2009/04/05 20:32:06 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -4326,7 +4326,7 @@ ExecInitExpr(Expr node, PlanState parent)`
`4326`	`4326`	`sstate = ExecInitSubPlan(subplan, parent);`
`4327`	`4327`
`4328`	`4328`	`/* Add SubPlanState nodes to parent->subPlan */`
`4329`		`- parent->subPlan = lcons(sstate, parent->subPlan);`
	`4329`	`+ parent->subPlan = lappend(parent->subPlan, sstate);`
`4330`	`4330`
`4331`	`4331`	`state = (ExprState *) sstate;`
`4332`	`4332`	`}`