Make sure that all <ctype.h> routines are called with unsigned char

tglsfdc · tglsfdc · commit ee051baeac9d · 2001-12-30T23:09:42.000Z
values; it's not portable to call them with signed chars.  I recall doing
this for the last release, but a few more uncasted calls have snuck in.
diff --git a/contrib/dbase/dbf2pg.c b/contrib/dbase/dbf2pg.c
@@ -78,7 +78,7 @@ isinteger(char *buff)
 				i++;
 				continue;
 			}
-		if (!isdigit((int) *i))
+		if (!isdigit((unsigned char) *i))
 			return 0;
 		i++;
 	}
@@ -90,7 +90,7 @@ strtoupper(char *string)
 {
 	while (*string != '\0')
 	{
-		*string = toupper(*string);
+		*string = toupper((unsigned char) *string);
 		string++;
 	}
 }
@@ -100,7 +100,7 @@ strtolower(char *string)
 {
 	while (*string != '\0')
 	{
-		*string = tolower(*string);
+		*string = tolower((unsigned char) *string);
 		string++;
 	}
 }
diff --git a/contrib/fuzzystrmatch/fuzzystrmatch.c b/contrib/fuzzystrmatch/fuzzystrmatch.c
@@ -253,17 +253,18 @@ metaphone(PG_FUNCTION_ARGS)
  * accesssing the array directly... */
 
 /* Look at the next letter in the word */
-#define Next_Letter (toupper(word[w_idx+1]))
+#define Next_Letter (toupper((unsigned char) word[w_idx+1]))
 /* Look at the current letter in the word */
-#define Curr_Letter (toupper(word[w_idx]))
+#define Curr_Letter (toupper((unsigned char) word[w_idx]))
 /* Go N letters back. */
-#define Look_Back_Letter(n) (w_idx >= n ? toupper(word[w_idx-n]) : '\0')
+#define Look_Back_Letter(n) \
+	(w_idx >= (n) ? toupper((unsigned char) word[w_idx-(n)]) : '\0')
 /* Previous letter.  I dunno, should this return null on failure? */
 #define Prev_Letter (Look_Back_Letter(1))
 /* Look two letters down.  It makes sure you don't walk off the string. */
-#define After_Next_Letter	(Next_Letter != '\0' ? toupper(word[w_idx+2]) \
-												 : '\0')
-#define Look_Ahead_Letter(n) (toupper(Lookahead(word+w_idx, n)))
+#define After_Next_Letter \
+	(Next_Letter != '\0' ? toupper((unsigned char) word[w_idx+2]) : '\0')
+#define Look_Ahead_Letter(n) toupper((unsigned char) Lookahead(word+w_idx, n))
 
 
 /* Allows us to safely look ahead an arbitrary # of letters */
@@ -291,7 +292,7 @@ Lookahead(char *word, int how_far)
 #define Phone_Len	(p_idx)
 
 /* Note is a letter is a 'break' in the word */
-#define Isbreak(c)	(!isalpha(c))
+#define Isbreak(c)	(!isalpha((unsigned char) (c)))
 
 
 int
@@ -336,7 +337,7 @@ _metaphone(
 
 	/*-- The first phoneme has to be processed specially. --*/
 	/* Find our first letter */
-	for (; !isalpha(Curr_Letter); w_idx++)
+	for (; !isalpha((unsigned char) (Curr_Letter)); w_idx++)
 	{
 		/* On the off chance we were given nothing but crap... */
 		if (Curr_Letter == '\0')
@@ -435,7 +436,7 @@ _metaphone(
 		 */
 
 		/* Ignore non-alphas */
-		if (!isalpha(Curr_Letter))
+		if (!isalpha((unsigned char) (Curr_Letter)))
 			continue;
 
 		/* Drop duplicates, except CC */
diff --git a/contrib/fuzzystrmatch/fuzzystrmatch.h b/contrib/fuzzystrmatch/fuzzystrmatch.h
@@ -153,7 +153,7 @@ char		_codes[26] = {
 };
 
 
-#define ENCODE(c) (isalpha(c) ? _codes[((toupper(c)) - 'A')] : 0)
+#define ENCODE(c) (isalpha((unsigned char) (c)) ? _codes[((toupper((unsigned char) (c))) - 'A')] : 0)
 
 #define isvowel(c)	(ENCODE(c) & 1)		/* AEIOU */
 
diff --git a/contrib/pgcrypto/pgcrypto.c b/contrib/pgcrypto/pgcrypto.c
@@ -26,7 +26,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $Id: pgcrypto.c,v 1.11 2001/11/20 15:50:53 momjian Exp $
+ * $Id: pgcrypto.c,v 1.12 2001/12/30 23:09:41 tgl Exp $
  */
 
 #include <postgres.h>
@@ -556,7 +556,7 @@ find_provider(text *name,
 
 	p = VARDATA(name);
 	for (i = 0; i < len; i++)
-		buf[i] = tolower(p[i]);
+		buf[i] = tolower((unsigned char) p[i]);
 	buf[len] = 0;
 
 	err = provider_lookup(buf, &res);
diff --git a/src/backend/utils/adt/datetime.c b/src/backend/utils/adt/datetime.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.85 2001/12/29 21:28:18 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.86 2001/12/30 23:09:41 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -959,7 +959,7 @@ DecodeDateTime(char **field, int *ftype, int nf,
 					if (tzp == NULL)
 						return -1;
 
-					if (isdigit(*field[i]) || ptype != 0)
+					if (isdigit((unsigned char) *field[i]) || ptype != 0)
 					{
 						char *cp;
 
@@ -1573,7 +1573,7 @@ DecodeTimeOnly(char **field, int *ftype, int nf,
 				/* otherwise, this is a time and/or time zone */
 				else
 				{
-					if (isdigit(*field[i]))
+					if (isdigit((unsigned char) *field[i]))
 					{
 						char *cp;
 
diff --git a/src/interfaces/odbc/connection.c b/src/interfaces/odbc/connection.c
@@ -1092,7 +1092,7 @@ CC_send_query(ConnectionClass *self, char *query, QueryInfo *qi)
 
 	ReadyToReturn = FALSE;
 	empty_reqs = 0;
-	for (wq = query; isspace(*wq); wq++)
+	for (wq = query; isspace((unsigned char) *wq); wq++)
 		;
 	if (*wq == '\0')
 		empty_reqs = 1;
diff --git a/src/interfaces/odbc/convert.c b/src/interfaces/odbc/convert.c
@@ -193,7 +193,7 @@ timestamp2stime(const char *str, SIMPLE_TIME *st, BOOL *bZone, int *zone)
 			}
 			for (i = 1; i < 10; i++)
 			{
-				if (!isdigit(rest[i]))
+				if (!isdigit((unsigned char) rest[i]))
 					break;
 			}
 			for (; i < 10; i++)
@@ -1351,7 +1351,7 @@ copy_statement_with_parameters(StatementClass *stmt)
 					while (isspace((unsigned char) old_statement[++opos]));
 				}
 				if (strnicmp(&old_statement[opos], "call", lit_call_len) ||
-					!isspace(old_statement[opos + lit_call_len]))
+					!isspace((unsigned char) old_statement[opos + lit_call_len]))
 				{
 					opos--;
 					continue;
@@ -1407,7 +1407,7 @@ copy_statement_with_parameters(StatementClass *stmt)
 				in_dquote = TRUE;
 			else
 			{
-				if (isspace(oldchar))
+				if (isspace((unsigned char) oldchar))
 				{
 					if (!prev_token_end)
 					{

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ isinteger(char *buff)`
`78`	`78`	`i++;`
`79`	`79`	`continue;`
`80`	`80`	`}`
`81`		`- if (!isdigit((int) *i))`
	`81`	`+ if (!isdigit((unsigned char) *i))`
`82`	`82`	`return 0;`
`83`	`83`	`i++;`
`84`	`84`	`}`
`@@ -90,7 +90,7 @@ strtoupper(char *string)`
`90`	`90`	`{`
`91`	`91`	`while (*string != '\0')`
`92`	`92`	`{`
`93`		`- string = toupper(string);`
	`93`	`+ string = toupper((unsigned char) string);`
`94`	`94`	`string++;`
`95`	`95`	`}`
`96`	`96`	`}`
`@@ -100,7 +100,7 @@ strtolower(char *string)`
`100`	`100`	`{`
`101`	`101`	`while (*string != '\0')`
`102`	`102`	`{`
`103`		`- string = tolower(string);`
	`103`	`+ string = tolower((unsigned char) string);`
`104`	`104`	`string++;`
`105`	`105`	`}`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.85 2001/12/29 21:28:18 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/datetime.c,v 1.86 2001/12/30 23:09:41 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -959,7 +959,7 @@ DecodeDateTime(char *field, int ftype, int nf,`
`959`	`959`	`if (tzp == NULL)`
`960`	`960`	`return -1;`
`961`	`961`
`962`		`- if (isdigit(*field[i]) \|\| ptype != 0)`
	`962`	`+ if (isdigit((unsigned char) *field[i]) \|\| ptype != 0)`
`963`	`963`	`{`
`964`	`964`	`char *cp;`
`965`	`965`
`@@ -1573,7 +1573,7 @@ DecodeTimeOnly(char *field, int ftype, int nf,`
`1573`	`1573`	`/* otherwise, this is a time and/or time zone */`
`1574`	`1574`	`else`
`1575`	`1575`	`{`
`1576`		`- if (isdigit(*field[i]))`
	`1576`	`+ if (isdigit((unsigned char) *field[i]))`
`1577`	`1577`	`{`
`1578`	`1578`	`char *cp;`
`1579`	`1579`
Original file line number	Diff line number	Diff line change
`@@ -1092,7 +1092,7 @@ CC_send_query(ConnectionClass self, char query, QueryInfo *qi)`
`1092`	`1092`
`1093`	`1093`	`ReadyToReturn = FALSE;`
`1094`	`1094`	`empty_reqs = 0;`
`1095`		`- for (wq = query; isspace(*wq); wq++)`
	`1095`	`+ for (wq = query; isspace((unsigned char) *wq); wq++)`
`1096`	`1096`	`;`
`1097`	`1097`	`if (*wq == '\0')`
`1098`	`1098`	`empty_reqs = 1;`
Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ timestamp2stime(const char str, SIMPLE_TIME st, BOOL bZone, int zone)`
`193`	`193`	`}`
`194`	`194`	`for (i = 1; i < 10; i++)`
`195`	`195`	`{`
`196`		`- if (!isdigit(rest[i]))`
	`196`	`+ if (!isdigit((unsigned char) rest[i]))`
`197`	`197`	`break;`
`198`	`198`	`}`
`199`	`199`	`for (; i < 10; i++)`
`@@ -1351,7 +1351,7 @@ copy_statement_with_parameters(StatementClass *stmt)`
`1351`	`1351`	`while (isspace((unsigned char) old_statement[++opos]));`
`1352`	`1352`	`}`
`1353`	`1353`	`if (strnicmp(&old_statement[opos], "call", lit_call_len) \|\|`
`1354`		`- !isspace(old_statement[opos + lit_call_len]))`
	`1354`	`+ !isspace((unsigned char) old_statement[opos + lit_call_len]))`
`1355`	`1355`	`{`
`1356`	`1356`	`opos--;`
`1357`	`1357`	`continue;`
`@@ -1407,7 +1407,7 @@ copy_statement_with_parameters(StatementClass *stmt)`
`1407`	`1407`	`in_dquote = TRUE;`
`1408`	`1408`	`else`
`1409`	`1409`	`{`
`1410`		`- if (isspace(oldchar))`
	`1410`	`+ if (isspace((unsigned char) oldchar))`
`1411`	`1411`	`{`
`1412`	`1412`	`if (!prev_token_end)`
`1413`	`1413`	`{`