Fix function code in error report

alvherre · alvherre · commit eee381ef5ec4 · 2018-06-06T14:48:08.000-04:00
This bug causes a lseek() failure to be reported as a "could not open" failure in the error message, muddling bug reports. I introduced this copy-and-pasteo in commit 78e1220. Noticed while reviewing code for bug report #15221, from lily liang. In version 10 the affected function is only used by multixact.c and commit_ts, and only in corner-case circumstances, neither of which are involved in the reported bug (a pg_subtrans failure.) Author: Álvaro Herrera
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
@@ -614,7 +614,7 @@ SimpleLruDoesPhysicalPageExist(SlruCtl ctl, int pageno)
 
 	if ((endpos = lseek(fd, 0, SEEK_END)) < 0)
 	{
-		slru_errcause = SLRU_OPEN_FAILED;
+		slru_errcause = SLRU_SEEK_FAILED;
 		slru_errno = errno;
 		SlruReportIOError(ctl, pageno, 0);
 	}

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ SimpleLruDoesPhysicalPageExist(SlruCtl ctl, int pageno)`
`614`	`614`
`615`	`615`	`if ((endpos = lseek(fd, 0, SEEK_END)) < 0)`
`616`	`616`	`{`
`617`		`- slru_errcause = SLRU_OPEN_FAILED;`
	`617`	`+ slru_errcause = SLRU_SEEK_FAILED;`
`618`	`618`	`slru_errno = errno;`
`619`	`619`	`SlruReportIOError(ctl, pageno, 0);`
`620`	`620`	`}`