use quote_ident() on schema in get_schema_qualified_name(), fix typos found by codespell

funbringer · funbringer · commit f0b9bac2fb87 · 2016-06-23T15:12:03.000+03:00
diff --git a/README.md b/README.md
@@ -192,7 +192,7 @@ EXPLAIN SELECT * FROM items WHERE id = 1234;
    ->  Index Scan using items_34_pkey on items_34  (cost=0.28..8.29 rows=0 width=0)
          Index Cond: (id = 1234)
 ```
-Note that pg_pathman exludes parent table from the query plan. To access parent table use ONLY modifier:
+Note that pg_pathman excludes parent table from the query plan. To access parent table use ONLY modifier:
 ```
 EXPLAIN SELECT * FROM ONLY items;
                       QUERY PLAN                      
diff --git a/init.sql b/init.sql
@@ -259,7 +259,11 @@ CREATE OR REPLACE FUNCTION @extschema@.get_schema_qualified_name(
 RETURNS TEXT AS
 $$
 BEGIN
-	RETURN relnamespace::regnamespace || delimiter || quote_ident(relname || suffix) FROM pg_class WHERE oid = cls::oid;
+	RETURN (SELECT quote_ident(relnamespace::regnamespace::text) ||
+				   delimiter ||
+				   quote_ident(relname || suffix)
+			FROM pg_class
+			WHERE oid = cls::oid);
 END
 $$
 LANGUAGE plpgsql;
@@ -271,23 +275,23 @@ CREATE OR REPLACE FUNCTION @extschema@.validate_relations_equality(relation1 OID
 RETURNS BOOLEAN AS
 $$
 DECLARE
-    rec RECORD;
+	rec RECORD;
 BEGIN
-    FOR rec IN (
-        WITH
-            a1 AS (select * from pg_attribute where attrelid = relation1 and attnum > 0),
-            a2 AS (select * from pg_attribute where attrelid = relation2 and attnum > 0)
-        SELECT a1.attname name1, a2.attname name2, a1.atttypid type1, a2.atttypid type2
-        FROM a1
-        FULL JOIN a2 ON a1.attnum = a2.attnum
-    )
-    LOOP
-        IF rec.name1 IS NULL OR rec.name2 IS NULL OR rec.name1 != rec.name2 THEN
-            RETURN False;
-        END IF;
-    END LOOP;
-
-    RETURN True;
+	FOR rec IN (
+		WITH
+			a1 AS (select * from pg_attribute where attrelid = relation1 and attnum > 0),
+			a2 AS (select * from pg_attribute where attrelid = relation2 and attnum > 0)
+		SELECT a1.attname name1, a2.attname name2, a1.atttypid type1, a2.atttypid type2
+		FROM a1
+		FULL JOIN a2 ON a1.attnum = a2.attnum
+	)
+	LOOP
+		IF rec.name1 IS NULL OR rec.name2 IS NULL OR rec.name1 != rec.name2 THEN
+			RETURN False;
+		END IF;
+	END LOOP;
+
+	RETURN True;
 END
 $$
 LANGUAGE plpgsql;
diff --git a/range.sql b/range.sql
@@ -619,7 +619,7 @@ LANGUAGE plpgsql;
  * partition will be destroyed.
  *
  * Notes: dummy field is used to pass the element type to the function
- * (it is neccessary because of pseudo-types used in function)
+ * (it is necessary because of pseudo-types used in function)
  */
 CREATE OR REPLACE FUNCTION @extschema@.merge_range_partitions_internal(
 	p_parent_relid OID

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,7 @@ LANGUAGE plpgsql;`
`619`	`619`	`* partition will be destroyed.`
`620`	`620`	`*`
`621`	`621`	`* Notes: dummy field is used to pass the element type to the function`
`622`		`- * (it is neccessary because of pseudo-types used in function)`
	`622`	`+ * (it is necessary because of pseudo-types used in function)`
`623`	`623`	`*/`
`624`	`624`	`CREATE OR REPLACE FUNCTION @extschema@.merge_range_partitions_internal(`
`625`	`625`	`p_parent_relid OID`