Allow CASE statement to contain *only* untyped result clauses or nulls.

Thomas G. Lockhart · Thomas G. Lockhart · commit f0f73b316d33 · 1999-09-13T04:14:56.000Z
Almost worked before, but forgot one place to check.
 Reported by Tatsuo Ishii.
Still does not do the right thing if inserting into a non-string target
 column. Should look for a type coersion later, but doesn't.
diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.57 1999/08/25 23:21:34 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.58 1999/09/13 04:14:56 thomas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -410,7 +410,8 @@ transformExpr(ParseState *pstate, Node *expr, int precedence)
 					 * only bother with conversion if not NULL and
 					 * different type...
 					 */
-					if (wtype && (wtype != ptype))
+					if (wtype && (wtype != UNKNOWNOID)
+						&& (wtype != ptype))
 					{
 						if (can_coerce_type(1, &wtype, &ptype))
 						{

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.57 1999/08/25 23:21:34 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.58 1999/09/13 04:14:56 thomas Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -410,7 +410,8 @@ transformExpr(ParseState pstate, Node expr, int precedence)`
`410`	`410`	`* only bother with conversion if not NULL and`
`411`	`411`	`* different type...`
`412`	`412`	`*/`
`413`		`- if (wtype && (wtype != ptype))`
	`413`	`+ if (wtype && (wtype != UNKNOWNOID)`
	`414`	`+ && (wtype != ptype))`
`414`	`415`	`{`
`415`	`416`	`if (can_coerce_type(1, &wtype, &ptype))`
`416`	`417`	`{`