pg_basebackup: canonicalize old and new tablespace paths

bmomjian · bmomjian · commit f19d8f14c776 · 2015-04-28T20:12:10.000-04:00
This avoids problems with double-slash-specified paths.

Patch by Ian Barwick
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -199,6 +199,9 @@ tablespace_list_append(const char *arg)
 		exit(1);
 	}
 
+	canonicalize_path(cell->old_dir);
+	canonicalize_path(cell->new_dir);
+
 	if (tablespace_dirs.tail)
 		tablespace_dirs.tail->next = cell;
 	else

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,9 @@ tablespace_list_append(const char *arg)`
`199`	`199`	`exit(1);`
`200`	`200`	`}`
`201`	`201`
	`202`	`+ canonicalize_path(cell->old_dir);`
	`203`	`+ canonicalize_path(cell->new_dir);`
	`204`	`+`
`202`	`205`	`if (tablespace_dirs.tail)`
`203`	`206`	`tablespace_dirs.tail->next = cell;`
`204`	`207`	`else`