Use correct symbol for minimum int64 value

petere · petere · commit f36ca9af05dd · 2016-07-17T09:15:37.000-04:00
The old code used SEQ_MINVALUE to get the smallest int64 value.  This
was done as a convenience to avoid having to deal with INT64_IS_BUSTED,
but that is obsolete now.  Also, it is incorrect because the smallest
int64 value is actually SEQ_MINVALUE-1.  Fix by using PG_INT64_MIN.
diff --git a/contrib/btree_gin/btree_gin.c b/contrib/btree_gin/btree_gin.c
@@ -223,10 +223,7 @@ GIN_SUPPORT(int4, false, leftmostvalue_int4, btint4cmp)
 static Datum
 leftmostvalue_int8(void)
 {
-	/*
-	 * Use sequence's definition to keep compatibility.
-	 */
-	return Int64GetDatum(SEQ_MINVALUE);
+	return Int64GetDatum(PG_INT64_MIN);
 }
 
 GIN_SUPPORT(int8, false, leftmostvalue_int8, btint8cmp)
@@ -250,10 +247,7 @@ GIN_SUPPORT(float8, false, leftmostvalue_float8, btfloat8cmp)
 static Datum
 leftmostvalue_money(void)
 {
-	/*
-	 * Use sequence's definition to keep compatibility.
-	 */
-	return Int64GetDatum(SEQ_MINVALUE);
+	return Int64GetDatum(PG_INT64_MIN);
 }
 
 GIN_SUPPORT(money, false, leftmostvalue_money, cash_cmp)

Original file line number	Diff line number	Diff line change
`@@ -223,10 +223,7 @@ GIN_SUPPORT(int4, false, leftmostvalue_int4, btint4cmp)`
`223`	`223`	`static Datum`
`224`	`224`	`leftmostvalue_int8(void)`
`225`	`225`	`{`
`226`		`- /*`
`227`		`- * Use sequence's definition to keep compatibility.`
`228`		`- */`
`229`		`- return Int64GetDatum(SEQ_MINVALUE);`
	`226`	`+ return Int64GetDatum(PG_INT64_MIN);`
`230`	`227`	`}`
`231`	`228`
`232`	`229`	`GIN_SUPPORT(int8, false, leftmostvalue_int8, btint8cmp)`
`@@ -250,10 +247,7 @@ GIN_SUPPORT(float8, false, leftmostvalue_float8, btfloat8cmp)`
`250`	`247`	`static Datum`
`251`	`248`	`leftmostvalue_money(void)`
`252`	`249`	`{`
`253`		`- /*`
`254`		`- * Use sequence's definition to keep compatibility.`
`255`		`- */`
`256`		`- return Int64GetDatum(SEQ_MINVALUE);`
	`250`	`+ return Int64GetDatum(PG_INT64_MIN);`
`257`	`251`	`}`
`258`	`252`
`259`	`253`	`GIN_SUPPORT(money, false, leftmostvalue_money, cash_cmp)`