Fix build_minmax_path() to cope if an IS NULL clause turns up in the

tglsfdc · tglsfdc · commit f538329f9db2 · 2007-12-03T22:37:17.000Z
indexable-clauses list for a btree index.  Formerly it just Asserted that
all such clauses were opclauses, but that's no longer true in 8.3.
Per bug #3796 from Matthias Schoeneich.
diff --git a/src/backend/optimizer/plan/planagg.c b/src/backend/optimizer/plan/planagg.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/optimizer/plan/planagg.c,v 1.34 2007/11/15 21:14:36 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/optimizer/plan/planagg.c,v 1.35 2007/12/03 22:37:17 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -368,7 +368,9 @@ build_minmax_path(PlannerInfo *root, RelOptInfo *rel, MinMaxAggInfo *info)
 				RestrictInfo *rinfo = (RestrictInfo *) lfirst(ll);
 				int			strategy;
 
-				Assert(is_opclause(rinfo->clause));
+				/* Could be an IS_NULL test, if so ignore */
+				if (!is_opclause(rinfo->clause))
+					continue;
 				strategy =
 					get_op_opfamily_strategy(((OpExpr *) rinfo->clause)->opno,
 											 index->opfamily[prevcol]);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/optimizer/plan/planagg.c,v 1.34 2007/11/15 21:14:36 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/plan/planagg.c,v 1.35 2007/12/03 22:37:17 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -368,7 +368,9 @@ build_minmax_path(PlannerInfo root, RelOptInfo rel, MinMaxAggInfo *info)`
`368`	`368`	`RestrictInfo rinfo = (RestrictInfo ) lfirst(ll);`
`369`	`369`	`int strategy;`
`370`	`370`
`371`		`- Assert(is_opclause(rinfo->clause));`
	`371`	`+ /* Could be an IS_NULL test, if so ignore */`
	`372`	`+ if (!is_opclause(rinfo->clause))`
	`373`	`+ continue;`
`372`	`374`	`strategy =`
`373`	`375`	`get_op_opfamily_strategy(((OpExpr *) rinfo->clause)->opno,`
`374`	`376`	`index->opfamily[prevcol]);`