make function disable_pathman_for() also remove row in pathman_config_params

funbringer · funbringer · commit f6548bae0394 · 2016-11-25T15:08:42.000+03:00
diff --git a/expected/pathman_calamity.out b/expected/pathman_calamity.out
@@ -303,6 +303,39 @@ SELECT create_hash_partitions('calamity.hash_two_times', 'val', 2);
 
 SELECT create_hash_partitions_internal('calamity.hash_two_times', 'val', 2);
 ERROR:  cannot add new HASH partitions
+/* check function disable_pathman_for() */
+CREATE TABLE calamity.to_be_disabled(val INT NOT NULL);
+SELECT create_hash_partitions('calamity.to_be_disabled', 'val', 3);	/* add row to main config */
+ create_hash_partitions 
+------------------------
+                      3
+(1 row)
+
+SELECT set_enable_parent('calamity.to_be_disabled', true); /* add row to params */
+ set_enable_parent 
+-------------------
+ 
+(1 row)
+
+SELECT disable_pathman_for('calamity.to_be_disabled'); /* should delete both rows */
+NOTICE:  function calamity.to_be_disabled_upd_trig_func() does not exist, skipping
+ disable_pathman_for 
+---------------------
+ 
+(1 row)
+
+SELECT count(*) FROM pathman_config WHERE partrel = 'calamity.to_be_disabled'::REGCLASS;
+ count 
+-------
+     0
+(1 row)
+
+SELECT count(*) FROM pathman_config_params WHERE partrel = 'calamity.to_be_disabled'::REGCLASS;
+ count 
+-------
+     0
+(1 row)
+
 DROP SCHEMA calamity CASCADE;
-NOTICE:  drop cascades to 11 other objects
+NOTICE:  drop cascades to 15 other objects
 DROP EXTENSION pg_pathman;
diff --git a/init.sql b/init.sql
@@ -340,7 +340,11 @@ $$
 BEGIN
 	PERFORM @extschema@.validate_relname(parent_relid);
 
+	/* Delete rows from both config tables */
 	DELETE FROM @extschema@.pathman_config WHERE partrel = parent_relid;
+	DELETE FROM @extschema@.pathman_config_params WHERE partrel = parent_relid;
+
+	/* Drop triggers on update */
 	PERFORM @extschema@.drop_triggers(parent_relid);
 
 	/* Notify backend about changes */
diff --git a/sql/pathman_calamity.sql b/sql/pathman_calamity.sql
@@ -114,6 +114,14 @@ CREATE TABLE calamity.hash_two_times(val serial);
 SELECT create_hash_partitions('calamity.hash_two_times', 'val', 2);
 SELECT create_hash_partitions_internal('calamity.hash_two_times', 'val', 2);
 
+/* check function disable_pathman_for() */
+CREATE TABLE calamity.to_be_disabled(val INT NOT NULL);
+SELECT create_hash_partitions('calamity.to_be_disabled', 'val', 3);	/* add row to main config */
+SELECT set_enable_parent('calamity.to_be_disabled', true); /* add row to params */
+SELECT disable_pathman_for('calamity.to_be_disabled'); /* should delete both rows */
+SELECT count(*) FROM pathman_config WHERE partrel = 'calamity.to_be_disabled'::REGCLASS;
+SELECT count(*) FROM pathman_config_params WHERE partrel = 'calamity.to_be_disabled'::REGCLASS;
+
 
 DROP SCHEMA calamity CASCADE;
 DROP EXTENSION pg_pathman;
