Clean up a few fprintf(stderr)'s that should be elog's.

tglsfdc · tglsfdc · commit f6e0130b5bee · 2002-11-02T15:54:13.000Z
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.108 2002/10/07 17:04:30 tgl Exp $
+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.109 2002/11/02 15:54:12 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1206,13 +1206,12 @@ XLogFlush(XLogRecPtr record)
 
 	if (XLOG_DEBUG)
 	{
-		elog(LOG, "XLogFlush%s%s: request %X/%X; write %X/%X; flush %X/%X\n",
+		elog(LOG, "XLogFlush%s%s: request %X/%X; write %X/%X; flush %X/%X",
 			 (IsBootstrapProcessingMode()) ? "(bootstrap)" : "",
 			 (InRedo) ? "(redo)" : "",
 			 record.xlogid, record.xrecoff,
 			 LogwrtResult.Write.xlogid, LogwrtResult.Write.xrecoff,
 			 LogwrtResult.Flush.xlogid, LogwrtResult.Flush.xrecoff);
-		fflush(stderr);
 	}
 
 	/* Disabled during REDO */
diff --git a/src/backend/executor/nodeSort.c b/src/backend/executor/nodeSort.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/executor/nodeSort.c,v 1.36 2002/06/20 20:29:28 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/executor/nodeSort.c,v 1.37 2002/11/02 15:54:13 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -186,7 +186,7 @@ ExecSort(Sort *node)
 		 * finally set the sorted flag to true
 		 */
 		sortstate->sort_Done = true;
-		SO1_printf(stderr, "ExecSort: sorting done.\n");
+		SO1_printf("ExecSort: %s\n", "sorting done");
 	}
 
 	SO1_printf("ExecSort: %s\n",
diff --git a/src/backend/utils/init/findbe.c b/src/backend/utils/init/findbe.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.30 2002/09/04 20:31:31 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/init/Attic/findbe.c,v 1.31 2002/11/02 15:54:13 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -174,8 +174,7 @@ FindExec(char *full_path, const char *argv0, const char *binary_name)
 			elog(DEBUG1, "FindExec: found \"%s\" using argv[0]", full_path);
 			return 0;
 		}
-		fprintf(stderr, "FindExec: invalid binary \"%s\"\n",
-				buf);
+		elog(LOG, "FindExec: invalid binary \"%s\"", buf);
 		return -1;
 	}
 
@@ -213,8 +212,7 @@ FindExec(char *full_path, const char *argv0, const char *binary_name)
 				case -1:		/* wasn't even a candidate, keep looking */
 					break;
 				case -2:		/* found but disqualified */
-					fprintf(stderr, "FindExec: could not read binary \"%s\"\n",
-							buf);
+					elog(LOG, "FindExec: could not read binary \"%s\"", buf);
 					free(path);
 					return -1;
 			}
@@ -224,6 +222,6 @@ FindExec(char *full_path, const char *argv0, const char *binary_name)
 		free(path);
 	}
 
-	fprintf(stderr, "FindExec: could not find a %s to execute...\n", binary_name);
+	elog(LOG, "FindExec: could not find a %s to execute", binary_name);
 	return -1;
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.108 2002/10/07 17:04:30 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.109 2002/11/02 15:54:12 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1206,13 +1206,12 @@ XLogFlush(XLogRecPtr record)`
`1206`	`1206`
`1207`	`1207`	`if (XLOG_DEBUG)`
`1208`	`1208`	`{`
`1209`		`- elog(LOG, "XLogFlush%s%s: request %X/%X; write %X/%X; flush %X/%X\n",`
	`1209`	`+ elog(LOG, "XLogFlush%s%s: request %X/%X; write %X/%X; flush %X/%X",`
`1210`	`1210`	`(IsBootstrapProcessingMode()) ? "(bootstrap)" : "",`
`1211`	`1211`	`(InRedo) ? "(redo)" : "",`
`1212`	`1212`	`record.xlogid, record.xrecoff,`
`1213`	`1213`	`LogwrtResult.Write.xlogid, LogwrtResult.Write.xrecoff,`
`1214`	`1214`	`LogwrtResult.Flush.xlogid, LogwrtResult.Flush.xrecoff);`
`1215`		`- fflush(stderr);`
`1216`	`1215`	`}`
`1217`	`1216`
`1218`	`1217`	`/* Disabled during REDO */`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/executor/nodeSort.c,v 1.36 2002/06/20 20:29:28 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/executor/nodeSort.c,v 1.37 2002/11/02 15:54:13 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -186,7 +186,7 @@ ExecSort(Sort *node)`
`186`	`186`	`* finally set the sorted flag to true`
`187`	`187`	`*/`
`188`	`188`	`sortstate->sort_Done = true;`
`189`		`- SO1_printf(stderr, "ExecSort: sorting done.\n");`
	`189`	`+ SO1_printf("ExecSort: %s\n", "sorting done");`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`SO1_printf("ExecSort: %s\n",`