This patch logs the error code in the default case, so that the user

bmomjian · bmomjian · commit fb755b6dd469 · 2004-09-23T13:20:45.000Z
stands a chance of looking it up.  "Unrecognised error" is always
disheartening.  :-)

Dominic Mitchell
diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.49 2004/08/29 05:07:00 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.50 2004/09/23 13:20:45 momjian Exp $
  *
  * NOTES
  *	  The client *requires* a valid server certificate.  Since
@@ -1019,7 +1019,8 @@ open_client_SSL(PGconn *conn)
 	r = SSL_connect(conn->ssl);
 	if (r <= 0)
 	{
-		switch (SSL_get_error(conn->ssl, r))
+		int err = SSL_get_error(conn->ssl, r);
+		switch (err)
 		{
 			case SSL_ERROR_WANT_READ:
 				return PGRES_POLLING_READING;
@@ -1054,7 +1055,7 @@ open_client_SSL(PGconn *conn)
 
 			default:
 				printfPQExpBuffer(&conn->errorMessage,
-						 libpq_gettext("unrecognized SSL error code\n"));
+						 libpq_gettext("unrecognized SSL error code (%d)\n"), err);
 				close_SSL(conn);
 				return PGRES_POLLING_FAILED;
 		}

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.49 2004/08/29 05:07:00 momjian Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-secure.c,v 1.50 2004/09/23 13:20:45 momjian Exp $`
`15`	`15`	`*`
`16`	`16`	`* NOTES`
`17`	`17`	`* The client requires a valid server certificate. Since`
`@@ -1019,7 +1019,8 @@ open_client_SSL(PGconn *conn)`
`1019`	`1019`	`r = SSL_connect(conn->ssl);`
`1020`	`1020`	`if (r <= 0)`
`1021`	`1021`	`{`
`1022`		`- switch (SSL_get_error(conn->ssl, r))`
	`1022`	`+ int err = SSL_get_error(conn->ssl, r);`
	`1023`	`+ switch (err)`
`1023`	`1024`	`{`
`1024`	`1025`	`case SSL_ERROR_WANT_READ:`
`1025`	`1026`	`return PGRES_POLLING_READING;`
`@@ -1054,7 +1055,7 @@ open_client_SSL(PGconn *conn)`
`1054`	`1055`
`1055`	`1056`	`default:`
`1056`	`1057`	`printfPQExpBuffer(&conn->errorMessage,`
`1057`		`- libpq_gettext("unrecognized SSL error code\n"));`
	`1058`	`+ libpq_gettext("unrecognized SSL error code (%d)\n"), err);`
`1058`	`1059`	`close_SSL(conn);`
`1059`	`1060`	`return PGRES_POLLING_FAILED;`
`1060`	`1061`	`}`