Skip to content

Commit fbcdff3

Browse files
committed
Thinko in previous commit: ensure that MAX_SEND_SIZE is always greater
than XLOG_BLCKSZ, by defining it as 16 * XLOG_BLCKSZ rather than directly as 128k bytes.
1 parent ea55160 commit fbcdff3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/backend/replication/walsender.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
*
3131
*
3232
* IDENTIFICATION
33-
* $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.21 2010/05/26 22:21:33 heikki Exp $
33+
* $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.22 2010/05/26 22:34:49 heikki Exp $
3434
*
3535
*-------------------------------------------------------------------------
3636
*/
@@ -109,10 +109,10 @@ static void CheckClosedConnection(void);
109109
* We don't have a good idea of what a good value would be; there's some
110110
* overhead per message in both walsender and walreceiver, but on the other
111111
* hand sending large batches makes walsender less responsive to signals
112-
* because signals are checked only between messages. 128kB seems like
113-
* a reasonable guess for now.
112+
* because signals are checked only between messages. 128kB (with
113+
* default 8k blocks) seems like a reasonable guess for now.
114114
*/
115-
#define MAX_SEND_SIZE (128 * 1024)
115+
#define MAX_SEND_SIZE (XLOG_BLCKSZ * 16)
116116

117117
/* Main entry point for walsender process */
118118
int

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy