Fix stupid parenthesization mistake. Per bug #4728 from Bruce Toll.

tglsfdc · tglsfdc · commit fc022d72c79b · 2009-03-24T21:12:56.000Z
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/optimizer/plan/planner.c,v 1.251 2009/01/09 15:46:10 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/optimizer/plan/planner.c,v 1.252 2009/03/24 21:12:56 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2546,8 +2546,8 @@ get_column_info_for_window(PlannerInfo *root, WindowClause *wc, List *tlist,
 			if (list_length(new_pathkeys) > list_length(pathkeys))
 			{
 				/* this sort clause is actually significant */
-				*partColIdx[*partNumCols] = sortColIdx[scidx++];
-				*partOperators[*partNumCols] = sgc->eqop;
+				(*partColIdx)[*partNumCols] = sortColIdx[scidx++];
+				(*partOperators)[*partNumCols] = sgc->eqop;
 				(*partNumCols)++;
 				pathkeys = new_pathkeys;
 			}
@@ -2565,8 +2565,8 @@ get_column_info_for_window(PlannerInfo *root, WindowClause *wc, List *tlist,
 			if (list_length(new_pathkeys) > list_length(pathkeys))
 			{
 				/* this sort clause is actually significant */
-				*ordColIdx[*ordNumCols] = sortColIdx[scidx++];
-				*ordOperators[*ordNumCols] = sgc->eqop;
+				(*ordColIdx)[*ordNumCols] = sortColIdx[scidx++];
+				(*ordOperators)[*ordNumCols] = sgc->eqop;
 				(*ordNumCols)++;
 				pathkeys = new_pathkeys;
 			}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/optimizer/plan/planner.c,v 1.251 2009/01/09 15:46:10 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/plan/planner.c,v 1.252 2009/03/24 21:12:56 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2546,8 +2546,8 @@ get_column_info_for_window(PlannerInfo root, WindowClause wc, List *tlist,`
`2546`	`2546`	`if (list_length(new_pathkeys) > list_length(pathkeys))`
`2547`	`2547`	`{`
`2548`	`2548`	`/* this sort clause is actually significant */`
`2549`		`- partColIdx[partNumCols] = sortColIdx[scidx++];`
`2550`		`- partOperators[partNumCols] = sgc->eqop;`
	`2549`	`+ (partColIdx)[partNumCols] = sortColIdx[scidx++];`
	`2550`	`+ (partOperators)[partNumCols] = sgc->eqop;`
`2551`	`2551`	`(*partNumCols)++;`
`2552`	`2552`	`pathkeys = new_pathkeys;`
`2553`	`2553`	`}`
`@@ -2565,8 +2565,8 @@ get_column_info_for_window(PlannerInfo root, WindowClause wc, List *tlist,`
`2565`	`2565`	`if (list_length(new_pathkeys) > list_length(pathkeys))`
`2566`	`2566`	`{`
`2567`	`2567`	`/* this sort clause is actually significant */`
`2568`		`- ordColIdx[ordNumCols] = sortColIdx[scidx++];`
`2569`		`- ordOperators[ordNumCols] = sgc->eqop;`
	`2568`	`+ (ordColIdx)[ordNumCols] = sortColIdx[scidx++];`
	`2569`	`+ (ordOperators)[ordNumCols] = sgc->eqop;`
`2570`	`2570`	`(*ordNumCols)++;`
`2571`	`2571`	`pathkeys = new_pathkeys;`
`2572`	`2572`	`}`