[PBCKP-278] ptrack adapted to hadling cfs relations

Daniel Shelepanov · Daniel Shelepanov · commit 0770988e7fae · 2022-11-11T11:07:56.000+03:00
tags: cfs, ptrack
diff --git a/engine.c b/engine.c
@@ -18,7 +18,6 @@
  */
 
 #include "postgres.h"
-
 #include <unistd.h>
 #include <sys/stat.h>
 
@@ -36,6 +35,10 @@
 #include "catalog/pg_tablespace.h"
 #include "miscadmin.h"
 #include "port/pg_crc32c.h"
+#ifdef PGPRO_EE
+/* For file_is_in_cfs_tablespace() only. */
+#include "common/cfs_common.h"
+#endif
 #include "storage/copydir.h"
 #if PG_VERSION_NUM >= 120000
 #include "storage/md.h"
@@ -91,6 +94,68 @@ ptrack_write_chunk(int fd, pg_crc32c *crc, char *chunk, size_t size)
 	}
 }
 
+/*
+ * Determines a file type which is one of the following:
+ * * regular relation file
+ * * regular relation file which is a part of a multifile relation
+ * * everythong else
+ */
+FileType
+file_type_from_path(const char *filename) {
+	ssize_t len = strlen(filename);
+	bool    met_dot;
+	met_dot = false;
+
+	// For this length checks we assume that the filename is at least
+	// 1 character longer than the corresponding extension ".cfm":
+	// strlen(".cfm") == 4 therefore we assume that the filename can't be
+	// shorter than 5 bytes, for example: "5.cfm".
+	if(len >= 5 && strcmp(&filename[len-4], ".cfm") == 0)
+		return FileTypeCFM;
+
+	// we expect filename to be ****/12345 or ****/12345.12
+	for(ssize_t i = len - 1; i >= 0 && filename[i] != '/'; i--) {
+		if(isdigit(filename[i]) != 0)
+			continue;
+
+		// we expect the dot to appear only once
+		if(filename[i] == '.') {
+			if(met_dot)
+				return FileTypeUnknown;
+
+			met_dot = true;
+		} else
+			// met anything except digit and dot => unknown file type
+			return FileTypeUnknown;
+	}
+
+	return met_dot ? FileTypeMainMulti : FileTypeMain;
+}
+
+#ifdef PGPRO_EE
+/*
+ * Determines the relation file size specified by fullpath as if it
+ * was not compressed.
+ */
+off_t
+get_cfs_relation_file_decompressed_size(RelFileNodeBackend rnode, const char *fullpath, ForkNumber forknum) {
+	File     fd;
+	int      compressor;
+	off_t    size;
+
+	compressor = md_get_compressor_internal(rnode.node, rnode.backend, forknum);
+	fd = PathNameOpenFile(fullpath, O_RDWR | PG_BINARY, compressor);
+
+	if(fd < 0)
+		return (off_t)-1;
+
+	size = FileSize(fd);
+	FileClose(fd);
+
+	return size;
+}
+#endif
+
 /*
  * Delete ptrack files when ptrack is disabled.
  *
@@ -498,8 +563,13 @@ assign_ptrack_map_size(int newval, void *extra)
  * For use in functions that copy directories bypassing buffer manager.
  */
 static void
+#ifdef PGPRO_EE
+ptrack_mark_file(Oid dbOid, Oid tablespaceOid,
+				 const char *filepath, const char *filename, bool is_cfs)
+#else
 ptrack_mark_file(Oid dbOid, Oid tablespaceOid,
 				 const char *filepath, const char *filename)
+#endif
 {
 	RelFileNodeBackend rnode;
 	ForkNumber	forknum;
@@ -508,6 +578,9 @@ ptrack_mark_file(Oid dbOid, Oid tablespaceOid,
 	struct stat stat_buf;
 	int			oidchars;
 	char		oidbuf[OIDCHARS + 1];
+#ifdef PGPRO_EE
+	off_t       rel_size;
+#endif
 
 	/* Do not track temporary relations */
 	if (looks_like_temp_rel_name(filename))
@@ -526,6 +599,21 @@ ptrack_mark_file(Oid dbOid, Oid tablespaceOid,
 	oidbuf[oidchars] = '\0';
 	nodeRel(nodeOf(rnode)) = atooid(oidbuf);
 
+#ifdef PGPRO_EE
+	// if current tablespace is cfs-compressed and md_get_compressor_internal
+	// returns the type of the compressing algorithm for filepath, then it
+	// needs to be de-compressed to obtain its size
+	if(is_cfs && md_get_compressor_internal(rnode.node, rnode.backend, forknum) != 0) {
+		rel_size = get_cfs_relation_file_decompressed_size(rnode, filepath, forknum);
+
+		if(rel_size == (off_t)-1) {
+			elog(WARNING, "ptrack: could not open cfs-compressed relation file: %s", filepath);
+			return;
+		}
+
+		nblocks = rel_size / BLCKSZ;
+	} else
+#endif
 	/* Compute number of blocks based on file size */
 	if (stat(filepath, &stat_buf) == 0)
 		nblocks = stat_buf.st_size / BLCKSZ;
@@ -546,6 +634,9 @@ ptrack_walkdir(const char *path, Oid tablespaceOid, Oid dbOid)
 {
 	DIR		   *dir;
 	struct dirent *de;
+#ifdef PGPRO_EE
+	bool        is_cfs;
+#endif
 
 	/* Do not walk during bootstrap and if ptrack is disabled */
 	if (ptrack_map_size == 0
@@ -554,6 +645,10 @@ ptrack_walkdir(const char *path, Oid tablespaceOid, Oid dbOid)
 		|| InitializingParallelWorker)
 		return;
 
+#ifdef PGPRO_EE
+	is_cfs = file_is_in_cfs_tablespace(path);
+#endif
+
 	dir = AllocateDir(path);
 
 	while ((de = ReadDirExtended(dir, path, LOG)) != NULL)
@@ -581,7 +676,11 @@ ptrack_walkdir(const char *path, Oid tablespaceOid, Oid dbOid)
 		}
 
 		if (S_ISREG(fst.st_mode))
+#ifdef PGPRO_EE
+			ptrack_mark_file(dbOid, tablespaceOid, subpath, de->d_name, is_cfs);
+#else
 			ptrack_mark_file(dbOid, tablespaceOid, subpath, de->d_name);
+#endif
 	}
 
 	FreeDir(dir);				/* we ignore any error here */
diff --git a/engine.h b/engine.h
@@ -73,6 +73,13 @@ typedef struct PtrackMapHdr
 
 typedef PtrackMapHdr * PtrackMap;
 
+typedef enum {
+	FileTypeUnknown,
+	FileTypeMain,
+	FileTypeMainMulti,
+	FileTypeCFM
+} FileType;
+
 /* Number of elements in ptrack map (LSN array)  */
 #define PtrackContentNblocks \
 		((ptrack_map_size - offsetof(PtrackMapHdr, entries) - sizeof(pg_crc32c)) / sizeof(pg_atomic_uint64))
@@ -111,4 +118,10 @@ extern void ptrack_walkdir(const char *path, Oid tablespaceOid, Oid dbOid);
 extern void ptrack_mark_block(RelFileNodeBackend smgr_rnode,
 							  ForkNumber forkno, BlockNumber blkno);
 
+extern FileType file_type_from_path(const char *path);
+#ifdef PGPRO_EE
+extern off_t    get_cfs_relation_file_decompressed_size(RelFileNodeBackend rnode,
+					const char *fullpath, ForkNumber forknum);
+#endif
+
 #endif							/* PTRACK_ENGINE_H */
diff --git a/ptrack.c b/ptrack.c
@@ -251,14 +251,6 @@ ptrack_copydir_hook(const char *path)
 
 	elog(DEBUG1, "ptrack_copydir_hook: spcOid %u, dbOid %u", spcOid, dbOid);
 
-#ifdef PGPRO_EE
-	/*
-	 * Currently, we do not track files from compressed tablespaces in ptrack.
-	 */
-	if (file_is_in_cfs_tablespace(path))
-		elog(DEBUG1, "ptrack_copydir_hook: skipping changes tracking in the CFS tablespace %u", spcOid);
-	else
-#endif
 	ptrack_walkdir(path, spcOid, dbOid);
 
 	if (prev_copydir_hook)
@@ -302,6 +294,10 @@ ptrack_gather_filelist(List **filelist, char *path, Oid spcOid, Oid dbOid)
 {
 	DIR		   *dir;
 	struct dirent *de;
+#ifdef PGPRO_EE
+	bool is_cfs;
+	is_cfs = file_is_in_cfs_tablespace(path);
+#endif
 
 	dir = AllocateDir(path);
 
@@ -315,7 +311,8 @@ ptrack_gather_filelist(List **filelist, char *path, Oid spcOid, Oid dbOid)
 
 		if (strcmp(de->d_name, ".") == 0 ||
 			strcmp(de->d_name, "..") == 0 ||
-			looks_like_temp_rel_name(de->d_name))
+			looks_like_temp_rel_name(de->d_name) ||
+			file_type_from_path(de->d_name) == FileTypeCFM)
 			continue;
 
 		snprintf(subpath, sizeof(subpath), "%s/%s", path, de->d_name);
@@ -362,6 +359,10 @@ ptrack_gather_filelist(List **filelist, char *path, Oid spcOid, Oid dbOid)
 				nodeSpc(pfl->relnode) = spcOid == InvalidOid ? DEFAULTTABLESPACE_OID : spcOid;
 				pfl->path = GetRelationPath(dbOid, nodeSpc(pfl->relnode),
 											nodeRel(pfl->relnode), InvalidBackendId, pfl->forknum);
+#ifdef PGPRO_EE
+				pfl->is_cfs_compressed = is_cfs
+					&& md_get_compressor_internal(pfl->relnode, InvalidBackendId, pfl->forknum) != 0;
+#endif
 
 				*filelist = lappend(*filelist, pfl);
 
@@ -403,6 +404,10 @@ ptrack_filelist_getnext(PtScanCtx * ctx)
 	ListCell   *cell;
 	char	   *fullpath;
 	struct stat fst;
+	off_t       rel_st_size = 0;
+#ifdef PGPRO_EE
+	RelFileNodeBackend rnodebackend;
+#endif
 
 	/* No more file in the list */
 	if (list_length(ctx->filelist) == 0)
@@ -449,14 +454,24 @@ ptrack_filelist_getnext(PtScanCtx * ctx)
 		return ptrack_filelist_getnext(ctx);
 	}
 
+#ifdef PGPRO_EE
+	rnodebackend.node = ctx->bid.relnode;
+	rnodebackend.backend = InvalidBackendId;
+
+	if(pfl->is_cfs_compressed)
+		rel_st_size = get_cfs_relation_file_decompressed_size(rnodebackend, fullpath, pfl->forknum);
+	else
+#endif
+	rel_st_size = fst.st_size;
+
 	if (pfl->segno > 0)
 	{
-		ctx->relsize = pfl->segno * RELSEG_SIZE + fst.st_size / BLCKSZ;
+		ctx->relsize = pfl->segno * RELSEG_SIZE + rel_st_size / BLCKSZ;
 		ctx->bid.blocknum = pfl->segno * RELSEG_SIZE;
 	}
 	else
 		/* Estimate relsize as size of first segment in blocks */
-		ctx->relsize = fst.st_size / BLCKSZ;
+		ctx->relsize = rel_st_size / BLCKSZ;
 
 	elog(DEBUG3, "ptrack: got file %s with size %u from the file list", pfl->path, ctx->relsize);
 
diff --git a/ptrack.h b/ptrack.h
@@ -78,6 +78,9 @@ typedef struct PtrackFileList_i
 	ForkNumber	forknum;
 	int			segno;
 	char	   *path;
+#ifdef PGPRO_EE
+	bool is_cfs_compressed;
+#endif
 }			PtrackFileList_i;
 
 #endif							/* PTRACK_H */
diff --git a/t/002_cfs_compatibility.pl b/t/002_cfs_compatibility.pl
