Throwing an error if there's a regex_t based affix instead of silently skipping them, which might lead to segfaults and so on (the extension can't handle them properly yet).

tvondra · tvondra · commit ae2f9d5936d9 · 2012-01-05T22:48:03.000+01:00
diff --git a/src/shared_ispell.c b/src/shared_ispell.c
@@ -619,7 +619,7 @@ AFFIX * copyAffix(AFFIX * affix) {
 		
 		/*FIXME Need to copy the regex_t properly. But would a plain copy be
 		 *      safe tu use by multiple processes at the same time? */
-		elog(WARNING, "skipping regex_t");
+		elog(ERROR, "This extension can't handle regex_t affixes yet.");
 		
 	}
 	
@@ -641,7 +641,7 @@ int sizeAffix(AFFIX * affix) {
 		
 		/*FIXME Need to copy the regex_t properly. But would a plain copy be
 		 *      safe tu use by multiple processes at the same time? */
-		elog(WARNING, "skipping regex_t");
+		elog(ERROR, "This extension can't handle regex_t affixes yet.");
 		
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,7 @@ AFFIX * copyAffix(AFFIX * affix) {`
`619`	`619`
`620`	`620`	`/*FIXME Need to copy the regex_t properly. But would a plain copy be`
`621`	`621`	`* safe tu use by multiple processes at the same time? */`
`622`		`- elog(WARNING, "skipping regex_t");`
	`622`	`+ elog(ERROR, "This extension can't handle regex_t affixes yet.");`
`623`	`623`
`624`	`624`	`}`
`625`	`625`
`@@ -641,7 +641,7 @@ int sizeAffix(AFFIX * affix) {`
`641`	`641`
`642`	`642`	`/*FIXME Need to copy the regex_t properly. But would a plain copy be`
`643`	`643`	`* safe tu use by multiple processes at the same time? */`
`644`		`- elog(WARNING, "skipping regex_t");`
	`644`	`+ elog(ERROR, "This extension can't handle regex_t affixes yet.");`
`645`	`645`
`646`	`646`	`}`
`647`	`647`