fix get_control_data()

funbringer · funbringer · commit 10f43fb52513 · 2017-11-03T17:38:07.000+03:00
diff --git a/testgres/testgres.py b/testgres/testgres.py
@@ -628,15 +628,15 @@ def get_control_data(self):
         else:
             _params = ["-D", self.data_dir]
 
-        lines = _execute_utility("pg_controldata", _params, self.utils_logname)
+        data = _execute_utility("pg_controldata", _params, self.utils_logname)
 
-        out_data = {}
+        out_dict = {}
 
-        for line in lines:
-            key, value = line.partition(':')[::2]
-            out_data[key.strip()] = value.strip()
+        for line in data.splitlines():
+            key, _, value = line.partition(':')
+            out_dict[key.strip()] = value.strip()
 
-        return out_data
+        return out_dict
 
     def start(self, params=[]):
         """
diff --git a/tests/test_simple.py b/tests/test_simple.py
@@ -155,7 +155,11 @@ def test_control_data(self):
             try:
                 node.init()
                 data = node.get_control_data()
+
+                # check returned dict
                 self.assertIsNotNone(data)
+                self.assertTrue(any('pg_control' in s for s in data.keys()))
+
             except ExecUtilException as e:
                 print(e.message)
                 got_exception = True
