Testgres tests create log dir in exact place (#243)

dmitry-lipetsk · web-flow · commit 2f550d878713 · 2025-05-01T23:21:48.000+03:00
When we do not define TEST_CFG__LOG_DIR it is expected the testgres tests will create a log directory in a root of testgres project folder.

We used config.rootpath for detect this folder in pytest_configure function.

It was occurred that config.rootpath can point to another (unexpected) place.

So we will use exact code to calculate testgres project folder (see TestStartupData.GetRootLogDir) to avid this problem.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -50,6 +50,17 @@ def CalcRootDir() -> str:
         r = os.path.abspath(r)
         return r
 
+    # --------------------------------------------------------------------
+    def CalcRootLogDir() -> str:
+        if TestConfigPropNames.TEST_CFG__LOG_DIR in os.environ:
+            resultPath = os.environ[TestConfigPropNames.TEST_CFG__LOG_DIR]
+        else:
+            rootDir = __class__.CalcRootDir()
+            resultPath = os.path.join(rootDir, "logs")
+
+        assert type(resultPath) == str  # noqa: E721
+        return resultPath
+
     # --------------------------------------------------------------------
     def CalcCurrentTestWorkerSignature() -> str:
         currentPID = os.getpid()
@@ -86,11 +97,18 @@ class TestStartupData:
         TestStartupData__Helper.CalcCurrentTestWorkerSignature()
     )
 
+    sm_RootLogDir: str = TestStartupData__Helper.CalcRootLogDir()
+
     # --------------------------------------------------------------------
     def GetRootDir() -> str:
         assert type(__class__.sm_RootDir) == str  # noqa: E721
         return __class__.sm_RootDir
 
+    # --------------------------------------------------------------------
+    def GetRootLogDir() -> str:
+        assert type(__class__.sm_RootLogDir) == str  # noqa: E721
+        return __class__.sm_RootLogDir
+
     # --------------------------------------------------------------------
     def GetCurrentTestWorkerSignature() -> str:
         assert type(__class__.sm_CurrentTestWorkerSignature) == str  # noqa: E721
@@ -954,13 +972,9 @@ def pytest_configure(config: pytest.Config) -> None:
     log_name = TestStartupData.GetCurrentTestWorkerSignature()
     log_name += ".log"
 
-    if TestConfigPropNames.TEST_CFG__LOG_DIR in os.environ:
-        log_path_v = os.environ[TestConfigPropNames.TEST_CFG__LOG_DIR]
-        log_path = pathlib.Path(log_path_v)
-    else:
-        log_path = config.rootpath.joinpath("logs")
+    log_dir = TestStartupData.GetRootLogDir()
 
-    log_path.mkdir(exist_ok=True)
+    pathlib.Path(log_dir).mkdir(exist_ok=True)
 
     logging_plugin: _pytest.logging.LoggingPlugin = config.pluginmanager.get_plugin(
         "logging-plugin"
@@ -969,7 +983,7 @@ def pytest_configure(config: pytest.Config) -> None:
     assert logging_plugin is not None
     assert isinstance(logging_plugin, _pytest.logging.LoggingPlugin)
 
-    logging_plugin.set_log_path(str(log_path / log_name))
+    logging_plugin.set_log_path(os.path.join(log_dir, log_name))
 
 
 # /////////////////////////////////////////////////////////////////////////////
