Skip to content

Commit 6115461

Browse files
author
vshepard
committed
PBCKP-781 change defaukt vakue PG_PROBACKUP_S3_HTTPS on ON
1 parent cfa6d28 commit 6115461

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

testgres/operations/remote_ops.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ def __init__(self, conn_params: ConnectionParams):
4848
self.ssh_key = conn_params.ssh_key
4949
self.port = conn_params.port
5050
self.ssh_cmd = ["-o StrictHostKeyChecking=no"]
51-
if self.ssh_key:
52-
self.ssh_cmd += ["-i", self.ssh_key]
5351
if self.port:
5452
self.ssh_cmd += ["-p", self.port]
53+
if self.ssh_key:
54+
self.ssh_cmd += ["-i", self.ssh_key]
5555
self.remote = True
5656
self.username = conn_params.username or self.get_user()
5757
self.tunnel_process = None
@@ -283,6 +283,7 @@ def write(self, filename, data, truncate=False, binary=False, read_and_write=Fal
283283
mode = "r+b" if binary else "r+"
284284

285285
with tempfile.NamedTemporaryFile(mode=mode, delete=False) as tmp_file:
286+
# Because in scp we set up port using -P option instead -p
286287
scp_ssh_cmd = ['-P' if x == '-p' else x for x in self.ssh_cmd]
287288

288289
if not truncate:
@@ -302,12 +303,11 @@ def write(self, filename, data, truncate=False, binary=False, read_and_write=Fal
302303
tmp_file.write(data)
303304

304305
tmp_file.flush()
305-
# Because in scp we set up port using -P option
306306
scp_cmd = ['scp'] + scp_ssh_cmd + [tmp_file.name, f"{self.username}@{self.host}:{filename}"]
307307
subprocess.run(scp_cmd, check=True)
308-
309308
remote_directory = os.path.dirname(filename)
310-
mkdir_cmd = ['ssh'] + scp_ssh_cmd + [f"{self.username}@{self.host}", f"mkdir -p {remote_directory}"]
309+
310+
mkdir_cmd = ['ssh'] + self.ssh_cmd + [f"{self.username}@{self.host}", f'mkdir -p {remote_directory}']
311311
subprocess.run(mkdir_cmd, check=True)
312312

313313
os.remove(tmp_file.name)
@@ -385,9 +385,10 @@ def get_process_children(self, pid):
385385
# Database control
386386
def db_connect(self, dbname, user, password=None, host="localhost", port=5432):
387387
"""
388-
Established SSH tunnel and Connects to a PostgreSQL
388+
Establish SSH tunnel and connect to a PostgreSQL database.
389389
"""
390-
self.establish_ssh_tunnel(local_port=reserve_port(), remote_port=5432)
390+
self.establish_ssh_tunnel(local_port=port, remote_port=self.conn_params.port)
391+
391392
try:
392393
conn = pglib.connect(
393394
host=host,
@@ -396,6 +397,11 @@ def db_connect(self, dbname, user, password=None, host="localhost", port=5432):
396397
user=user,
397398
password=password,
398399
)
400+
print("Database connection established successfully.")
399401
return conn
400402
except Exception as e:
401-
raise Exception(f"Could not connect to the database. Error: {e}")
403+
print(f"Error connecting to the database: {str(e)}")
404+
if self.tunnel_process:
405+
self.tunnel_process.terminate()
406+
print("SSH tunnel closed due to connection failure.")
407+
raise

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy