Add synchronous promotion support on pg of version < 10

zilder · zilder · commit 7c48faebc13e · 2018-06-04T14:57:44.000+03:00
diff --git a/testgres/node.py b/testgres/node.py
@@ -683,17 +683,19 @@ def reload(self, params=[]):
         _params = [
             get_bin_path("pg_ctl"),
             "-D", self.data_dir,
-            "-w",  # wait
             "reload"
         ] + params  # yapf: disable
 
         execute_utility(_params, self.utils_log_file)
 
         return self
 
-    def promote(self):
+    def promote(self, dbname=None, username=None):
         """
-        Promote standby instance to master using pg_ctl.
+        Promote standby instance to master using pg_ctl. For PostgreSQL versions
+        below 10 some additional actions required to ensure that instance
+        became writable and hence `dbname` and `username` parameters may be
+        needed.
 
         Returns:
             This instance of :class:`.PostgresNode`.
@@ -708,7 +710,19 @@ def promote(self):
 
         execute_utility(_params, self.utils_log_file)
 
-        # Node becomes master itself
+        # for versions below 10 `promote` is asynchronous so we need to wait
+        # until it actually becomes writable
+        if not pg_version_ge("10"):
+            check_query = "SHOW transaction_read_only"
+
+            self.poll_query_until(
+                query=check_query,
+                expected="on",
+                dbname=dbname,
+                username=username,
+                max_attempts=0)    # infinite
+
+        # node becomes master itself
         self._master = None
 
         return self
