RemoteOperations::exec_command updated (#185)

dmitry-lipetsk · web-flow · commit 7fd2f07af753 · 2025-02-20T14:56:02.000+03:00
- Exact enumeration of supported 'cmd' types
- Refactoring
diff --git a/testgres/operations/remote_ops.py b/testgres/operations/remote_ops.py
@@ -78,14 +78,17 @@ def exec_command(self, cmd, wait_exit=False, verbose=False, expect_error=False,
 
         assert input_prepared is None or (type(input_prepared) == bytes)  # noqa: E721
 
-        ssh_cmd = []
-        if isinstance(cmd, str):
-            ssh_cmd = ['ssh', self.ssh_dest] + self.ssh_args + [cmd]
-        elif isinstance(cmd, list):
-            ssh_cmd = ['ssh', self.ssh_dest] + self.ssh_args + [subprocess.list2cmdline(cmd)]
+        if type(cmd) == str:  # noqa: E721
+            cmd_s = cmd
+        elif type(cmd) == list:  # noqa: E721
+            cmd_s = subprocess.list2cmdline(cmd)
         else:
             raise ValueError("Invalid 'cmd' argument type - {0}".format(type(cmd).__name__))
 
+        assert type(cmd_s) == str  # noqa: E721
+
+        ssh_cmd = ['ssh', self.ssh_dest] + self.ssh_args + [cmd_s]
+
         process = subprocess.Popen(ssh_cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
         assert not (process is None)
         if get_process:
