A problem with tests.test_simple.TestgresTests.test_simple_with_bin_dir is fixed

dmitry-lipetsk · dmitry-lipetsk · commit 89c8625252be · 2025-02-17T14:02:24.000+03:00
testgres generates the exception testgres.exceptions.ExecUtilException, but test traps the exception FileNotFoundError.

Error message is:
 Utility exited with non-zero code. Error: `bash: line 1: wrong/path/postgres: No such file or directory`
 Command: ('wrong/path/postgres --version',)
diff --git a/tests/test_simple.py b/tests/test_simple.py
@@ -1244,13 +1244,19 @@ def test_simple_with_bin_dir(self):
         correct_bin_dir = app.make_simple(base_dir=node.base_dir, bin_dir=bin_dir)
         correct_bin_dir.slow_start()
         correct_bin_dir.safe_psql("SELECT 1;")
+        correct_bin_dir.stop()
+
+        while True:
+            try:
+                app.make_simple(base_dir=node.base_dir, bin_dir="wrong/path")
+            except FileNotFoundError:
+                break  # Expected error
+            except ExecUtilException:
+                break  # Expected error
 
-        try:
-            wrong_bin_dir = app.make_empty(base_dir=node.base_dir, bin_dir="wrong/path")
-            wrong_bin_dir.slow_start()
             raise RuntimeError("Error was expected.")  # We should not reach this
-        except FileNotFoundError:
-            pass  # Expected error
+
+        return
 
     def test_set_auto_conf(self):
         # elements contain [property id, value, storage value]
