PostgresNode::start is updated [no logging.error]

dmitry-lipetsk · dmitry-lipetsk · commit b91714142fb7 · 2025-04-01T09:01:54.000+03:00
It does not uses logging.error when it can't reallocate port number. It throws exception only.

Why? Our new test infrastructure will process logging.error and will increment an error counter. As result - some tests start failing.
diff --git a/testgres/node.py b/testgres/node.py
@@ -1038,8 +1038,7 @@ def LOCAL__raise_cannot_start_node__std(from_exception):
                     assert nAttempt > 0
                     assert nAttempt <= __class__._C_MAX_START_ATEMPTS
                     if nAttempt == __class__._C_MAX_START_ATEMPTS:
-                        logging.error("Reached maximum retry attempts. Unable to start node.")
-                        LOCAL__raise_cannot_start_node(e, "Cannot start node after multiple attempts")
+                        LOCAL__raise_cannot_start_node(e, "Cannot start node after multiple attempts.")
 
                     log_files1 = self._collect_log_files()
                     if not self._detect_port_conflict(log_files0, log_files1):
diff --git a/tests/test_simple.py b/tests/test_simple.py
@@ -450,7 +450,7 @@ def test_port_conflict(self):
 
                     with pytest.raises(
                         expected_exception=StartNodeException,
-                        match=re.escape("Cannot start node after multiple attempts")
+                        match=re.escape("Cannot start node after multiple attempts.")
                     ):
                         node2.init().start()
 
