Adapt to PG 12 where recovery.conf is obsolete.

arssher · arssher · commit ccdf25ec733f · 2019-11-18T21:11:46.000+03:00
diff --git a/testgres/node.py b/testgres/node.py
@@ -336,8 +336,15 @@ def _create_recovery_conf(self, username, slot=None):
 
         line = (
             "primary_conninfo='{}'\n"
-            "standby_mode=on\n"
         ).format(options_string(**conninfo))  # yapf: disable
+        # Since 12 recovery.conf had disappeared
+        if self.version >= '12':
+            signal_name = os.path.join(self.data_dir, "standby.signal")
+            # cross-python touch(). It is vulnerable to races, but who cares?
+            with open(signal_name, 'a'):
+                os.utime(signal_name, None)
+        else:
+            line += "standby_mode=on\n"
 
         if slot:
             # Connect to master for some additional actions
@@ -363,7 +370,10 @@ def _create_recovery_conf(self, username, slot=None):
 
             line += "primary_slot_name={}\n".format(slot)
 
-        self.append_conf(filename=RECOVERY_CONF_FILE, line=line)
+        if self.version >= '12':
+            self.append_conf(line=line)
+        else:
+            self.append_conf(filename=RECOVERY_CONF_FILE, line=line)
 
     def _maybe_start_logger(self):
         if testgres_config.use_python_logging:
