allow zero (infinite) 'max_attempts' in poll_query_until()

funbringer · funbringer · commit d7afaad5383c · 2017-11-24T17:42:24.000+03:00
diff --git a/testgres/testgres.py b/testgres/testgres.py
@@ -922,20 +922,25 @@ def poll_query_until(self,
                          raise_internal_error=True):
         """
         Run a query once a second until it returs 'expected'.
+        Query should return single column.
 
         Args:
             dbname: database name to connect to.
             query: query to be executed.
             username: database user name.
-            max_attempts: how many times should we try?
-            sleep_time: how long should we sleep after a failure?
+            max_attempts: how many times should we try? 0 == infinite
+            sleep_time: how much should we sleep after a failure?
             expected: what should be returned to break the cycle?
             raise_programming_error: mute ProgrammingError?
             raise_internal_error: mute InternalError?
         """
 
+        # sanity checks
+        assert(max_attempts >= 0)
+        assert(sleep_time > 0)
+
         attempts = 0
-        while attempts < max_attempts:
+        while max_attempts == 0 or attempts < max_attempts:
             try:
                 res = self.execute(dbname=dbname,
                                    query=query,
@@ -1010,7 +1015,7 @@ def replicate(self, name, username=None,
                   xlog_method=DEFAULT_XLOG_METHOD,
                   use_logging=False):
         """
-        Create a replica of this node.
+        Create a binary replica of this node.
 
         Args:
             name: replica's name.
