Consistently use tabs in ternaries when useTabs is true (#15662)

auvred · fisker · sosukesuzuki · web-flow · commit 0d1ffb3a914d · 2023-12-10T17:10:57.000+09:00
Co-authored-by: fisker Cheung &lt;lionkay@gmail.com&gt;
Co-authored-by: SUZUKI Sosuke &lt;aosukeke@gmail.com&gt;
diff --git a/changelog_unreleased/javascript/15662.md b/changelog_unreleased/javascript/15662.md
@@ -0,0 +1,31 @@
+#### Consistently use tabs in ternaries when `useTabs` is `true` (#15662 by @auvred)
+
+<!-- prettier-ignore -->
+```jsx
+// Input
+aaaaaaaaaaaaaaa
+	? bbbbbbbbbbbbbbbbbb
+	: ccccccccccccccc
+	  ? ddddddddddddddd
+	  : eeeeeeeeeeeeeee
+	    ? fffffffffffffff
+	    : gggggggggggggggg;
+
+// Prettier stable
+aaaaaaaaaaaaaaa
+	? bbbbbbbbbbbbbbbbbb
+	: ccccccccccccccc
+	  ? ddddddddddddddd
+	  : eeeeeeeeeeeeeee
+	    ? fffffffffffffff
+	    : gggggggggggggggg;
+
+// Prettier main
+aaaaaaaaaaaaaaa
+	? bbbbbbbbbbbbbbbbbb
+	: ccccccccccccccc
+		? ddddddddddddddd
+		: eeeeeeeeeeeeeee
+			? fffffffffffffff
+			: gggggggggggggggg;
+```
diff --git a/src/language-js/print/ternary-old.js b/src/language-js/print/ternary-old.js
@@ -274,16 +274,42 @@ function printTernaryOld(path, options, print) {
         : wrap(print(alternateNodePropertyName)),
     );
   } else {
+    /*
+    This does not mean to indent, but make the doc aligned with the first character after `? ` or `: `,
+    so we use `2` instead of `options.tabWidth` here.
+    
+    ```js
+    test
+     ? {
+         consequent
+       }
+     : alternate
+    ```
+
+    instead of
+    
+    ```js
+    test
+     ? {
+       consequent
+     }
+     : alternate
+    ```
+    */
+    const printBranch = (nodePropertyName) =>
+      options.useTabs
+        ? indent(print(nodePropertyName))
+        : align(2, print(nodePropertyName));
     // normal mode
     const part = [
       line,
       "? ",
       consequentNode.type === node.type ? ifBreak("", "(") : "",
-      align(2, print(consequentNodePropertyName)),
+      printBranch(consequentNodePropertyName),
       consequentNode.type === node.type ? ifBreak("", ")") : "",
       line,
       ": ",
-      align(2, print(alternateNodePropertyName)),
+      printBranch(alternateNodePropertyName),
     ];
     parts.push(
       parent.type !== node.type ||
diff --git a/tests/format/js/ternaries/__snapshots__/jsfmt.spec.js.snap b/tests/format/js/ternaries/__snapshots__/jsfmt.spec.js.snap
