Add per locale Intl memoizer

Demivan · Demivan · commit 3fe8b97420c7 · 2020-07-17T20:36:10.000+03:00
diff --git a/fluent-bundle/src/bundle.ts b/fluent-bundle/src/bundle.ts
@@ -4,6 +4,7 @@ import { FluentResource } from "./resource.js";
 import { FluentValue, FluentNone, FluentFunction } from "./types.js";
 import { Message, Term, Pattern } from "./ast.js";
 import { NUMBER, DATETIME } from "./builtins.js";
+import { getMemoizerForLocale } from "./memoizer.js";
 
 export type TextTransform = (text: string) => string;
 
@@ -22,7 +23,7 @@ export class FluentBundle {
   public _functions: Record<string, FluentFunction>;
   public _useIsolating: boolean;
   public _transform: TextTransform;
-  public _intls: WeakMap<object, Record<string, object>> = new WeakMap();
+  public _intls: WeakMap<object, Record<string, object>>;
 
   /**
    * Create an instance of `FluentBundle`.
@@ -73,6 +74,7 @@ export class FluentBundle {
     };
     this._useIsolating = useIsolating;
     this._transform = transform;
+    this._intls = getMemoizerForLocale(locales);
   }
 
   /**
diff --git a/fluent-bundle/src/memoizer.ts b/fluent-bundle/src/memoizer.ts
@@ -0,0 +1,14 @@
+type IntlCache = WeakMap<object, Record<string, object>>;
+
+const cache = new Map<string, IntlCache>();
+
+export function getMemoizerForLocale(locales: string | string[]): IntlCache {
+  const stringLocale = Array.isArray(locales) ? locales.join(" ") : locales;
+  let memoizer = cache.get(stringLocale);
+  if (memoizer === undefined) {
+    memoizer = new WeakMap();
+    cache.set(stringLocale, memoizer);
+  }
+
+  return memoizer;
+}
diff --git a/fluent-bundle/test/memoizer_test.js b/fluent-bundle/test/memoizer_test.js
@@ -0,0 +1,30 @@
+'use strict';
+
+import assert from 'assert';
+import {getMemoizerForLocale} from '../esm/memoizer';
+
+suite('Memoizer', function() {
+  test('returns same instance for same locale', function() {
+    const memoizer1 = getMemoizerForLocale('en')
+    const memoizer2 = getMemoizerForLocale('en')
+    assert.strictEqual(memoizer1, memoizer2)
+  });
+
+  test('returns different instance for different locale', function() {
+    const memoizer1 = getMemoizerForLocale('en')
+    const memoizer2 = getMemoizerForLocale('uk')
+    assert.notStrictEqual(memoizer1, memoizer2)
+  });
+
+  test('works with array of locales', function() {
+    const memoizer1 = getMemoizerForLocale(['en'])
+    const memoizer2 = getMemoizerForLocale(['en'])
+    assert.strictEqual(memoizer1, memoizer2)
+  });
+
+  test('works with string and array of locales', function() {
+    const memoizer1 = getMemoizerForLocale(['en'])
+    const memoizer2 = getMemoizerForLocale('en')
+    assert.strictEqual(memoizer1, memoizer2)
+  })
+})
