Renamed to_dense to to_vec

ankane · ankane · commit 8b6102f707bc · 2024-06-04T14:36:24.000-07:00
diff --git a/src/sparsevec.rs b/src/sparsevec.rs
@@ -48,8 +48,8 @@ impl SparseVector {
         }
     }
 
-    /// Returns the sparse vector as a dense vector.
-    pub fn to_dense(&self) -> Vec<f32> {
+    /// Returns the sparse vector as a `Vec<f32>`.
+    pub fn to_vec(&self) -> Vec<f32> {
         let mut vec = vec![0.0; self.dim];
         for (i, v) in self.indices.iter().zip(&self.values) {
             vec[*i as usize] = *v;
@@ -95,12 +95,12 @@ mod tests {
     #[test]
     fn test_from_dense() {
         let vec = SparseVector::from_dense(&[1.0, 0.0, 2.0, 0.0, 3.0, 0.0]);
-        assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_dense());
+        assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_vec());
     }
 
     #[test]
-    fn test_to_dense() {
+    fn test_to_vec() {
         let vec = SparseVector::new(6, vec![0, 2, 4], vec![1.0, 2.0, 3.0]);
-        assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_dense());
+        assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_vec());
     }
 }
diff --git a/src/sqlx_ext/sparsevec.rs b/src/sqlx_ext/sparsevec.rs
@@ -87,7 +87,7 @@ mod tests {
         .await?;
         let res_vec: SparseVector = row.try_get("embedding").unwrap();
         assert_eq!(vec, res_vec);
-        assert_eq!(vec![1.0, 2.0, 3.0], res_vec.to_dense());
+        assert_eq!(vec![1.0, 2.0, 3.0], res_vec.to_vec());
 
         let empty_vec = SparseVector::from_dense(&[]);
         let empty_res = sqlx::query("INSERT INTO sqlx_sparse_items (embedding) VALUES ($1)")

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ impl SparseVector {`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`
`51`		`- /// Returns the sparse vector as a dense vector.`
`52`		`- pub fn to_dense(&self) -> Vec<f32> {`
	`51`	+ /// Returns the sparse vector as a `Vec<f32>`.
	`52`	`+ pub fn to_vec(&self) -> Vec<f32> {`
`53`	`53`	`let mut vec = vec![0.0; self.dim];`
`54`	`54`	`for (i, v) in self.indices.iter().zip(&self.values) {`
`55`	`55`	`vec[i as usize] = v;`
`@@ -95,12 +95,12 @@ mod tests {`
`95`	`95`	`#[test]`
`96`	`96`	`fn test_from_dense() {`
`97`	`97`	`let vec = SparseVector::from_dense(&[1.0, 0.0, 2.0, 0.0, 3.0, 0.0]);`
`98`		`- assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_dense());`
	`98`	`+ assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_vec());`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`#[test]`
`102`		`- fn test_to_dense() {`
	`102`	`+ fn test_to_vec() {`
`103`	`103`	`let vec = SparseVector::new(6, vec![0, 2, 4], vec![1.0, 2.0, 3.0]);`
`104`		`- assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_dense());`
	`104`	`+ assert_eq!(vec![1.0, 0.0, 2.0, 0.0, 3.0, 0.0], vec.to_vec());`
`105`	`105`	`}`
`106`	`106`	`}`